CAMEL-23510: flag camel-jgroups header rename as potential breaking change in 4.18 upgrade guide#23471
Merged
oscerd merged 1 commit intoMay 22, 2026
Conversation
… change in 4.18 upgrade guide The JGroups header constant rename was also backported to camel-4.18.x (apache#23213) and documented in the 4.18 upgrade guide on main via the doc-sync apache#23219. As with the 4.14 and 4.21 guides, that entry does not explicitly call out that the rename is a breaking change for routes that read or write these headers by their literal string value. Update the 4.18 guide entry to: - Suffix the section heading with " - potential breaking change", the established convention in the upgrade guides. - Lead the post-table prose with an explicit "This is a breaking change for routes that ..." sentence. Keeps the 4.18 entry consistent with the equivalent wording on the 4.14 guide (apache#23422 / apache#23441) and the 4.21 guide (apache#23451). No code changes; docs only. Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
gnodet
approved these changes
May 22, 2026
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Looks good. The heading change matches the === camel-grok - potential breaking change convention already established in the 4.21 guide, and the added sentence clearly calls out the breaking-change impact for literal-string-based header references.
The wording is consistent with the already-merged companion PRs (#23422 for 4.14-on-main and #23451 for 4.21).
LGTM.
Claude Code on behalf of Guillaume Nodet
2 tasks
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
|
oscerd
added a commit
that referenced
this pull request
May 22, 2026
…hange in 4.14 upgrade guide (#23441) Follow-up to the camel-4.14.x backport #23421. Addresses @apupier's review comment on #23422: the JGroups header constant rename is a breaking change for routes that read or write the headers by their literal string value, so the 4.14 upgrade-guide entry now says so explicitly. - Heading suffixed with " - potential breaking change" (matching the camel-grok convention). - Prose leads with an explicit "This is a breaking change for routes that ..." sentence. Docs only; consistent with the same wording on the 4.14 guide on main (#23422), the 4.18 guide (#23471) and the 4.21 guide (#23451).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #23209 (CAMEL-23510) completing the breaking-change labelling across all affected upgrade guides.
The JGroups header constant rename was also backported to
camel-4.18.x(#23213) and documented onmain'scamel-4x-upgrade-guide-4_18.adocvia the doc-sync #23219. Like the 4.14 and 4.21 guides, that entry did not explicitly flag the rename as a breaking change — which @apupier asked for on #23422.This PR applies the same wording to the 4.18 guide entry.
Changes
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_18.adoc:=== camel-jgroups→=== camel-jgroups - potential breaking change(matching the existing=== camel-grok - potential breaking changeconvention).No code changes; pure docs update (7 insertions, 6 deletions).
Consistency across all guides
The identical wording now applies to every place the JGroups rename is documented:
camel-4.14.xmainmainmainRelated
Test plan
=== camel-grok - potential breaking changeconvention.Claude Code on behalf of Andrea Cosentino