Skip to content

feat(components): support telemetry include patterns#23500

Merged
squakez merged 2 commits into
apache:mainfrom
squakez:feat/CAMEL-23433
May 25, 2026
Merged

feat(components): support telemetry include patterns#23500
squakez merged 2 commits into
apache:mainfrom
squakez:feat/CAMEL-23433

Conversation

@squakez
Copy link
Copy Markdown
Contributor

@squakez squakez commented May 25, 2026

Closes CAMEL-23433

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@github-actions
Copy link
Copy Markdown
Contributor

ghost commented May 25, 2026

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@squakez squakez marked this pull request as ready for review May 25, 2026 08:40
@github-actions
Copy link
Copy Markdown
Contributor

ghost commented May 25, 2026

🧪 CI tested the following changed modules:

  • catalog/camel-catalog
  • components/camel-micrometer-observability
  • components/camel-opentelemetry2
  • components/camel-telemetry-dev
  • components/camel-telemetry
  • core/camel-main

ℹ️ Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the test-dependents label to force testing all dependents.

Build reactor — dependencies compiled but only changed modules were tested (6 modules)
  • Camel :: Catalog :: Camel Catalog
  • Camel :: Common Telemetry
  • Camel :: Main
  • Camel :: Micrometer :: Observability 2
  • Camel :: Opentelemetry 2
  • Camel :: Telemetry :: Dev

⚙️ View full build and test results

@squakez
Copy link
Copy Markdown
Contributor Author

squakez commented May 25, 2026

@davsclaus @oscerd @Croway please, have a look. As soon as it is merged I need to work on the runtimes as well. Thanks!

@squakez squakez merged commit 25c350f into apache:main May 25, 2026
7 checks passed
@squakez squakez deleted the feat/CAMEL-23433 branch May 25, 2026 13:56
|`disableCoreProcessors`| false | Disable any inner core processors (any core DSL processor provided in the route, for example `bean`, `log`, ...).
|`excludePatterns` | | Sets exclude pattern that will disable tracing for those spans that matches the pattern. The variable is a comma separated values of filters to execute (eg, `log*,direct*,setBody*`, ...)
| `excludePatterns` | | A comma-separated list of patterns (e.g., `log*,direct*,setBody*`) to exclude from tracing. Spans matching these patterns will be disabled. If nothing is specified, no processors are excluded by default.
| `includePatterns` | | A comma-separated list of patterns (e.g., `log*,direct*,setBody*`) to explicitly include in a trace. Spans matching these patterns will be enabled. If nothing is specified, all processors are included by default.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happen when excludePatterns and includePatterns are used together? exclude should win, do you think it is worth documenting this behaviour? @squakez

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pertinent question. However I think it is an implicit logic. If you include "a" and exclude "a", then you logically won't have "a". Also, I've added the "If nothing is specified, all processors are included by default" right to clarify that everything is included by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants