[backport camel-4.18.x] CAMEL-23590: camel-milo - align Exchange header constant names with Camel naming convention#23509
Merged
oscerd merged 1 commit intoMay 26, 2026
Conversation
…amel naming convention (apache#23474) * CAMEL-23590: camel-milo - align Exchange header constant names with Camel naming convention Renames the MiloConstants.HEADER_AWAIT header string value from "await" (which is outside the Camel namespace and therefore not filtered by the default HeaderFilterStrategy) to "CamelMiloAwait", following the convention used across the rest of the Camel component catalog and matching the pattern established in CAMEL-23526 (camel-cxf), CAMEL-23522 (camel-mail), CAMEL-23461 (camel-aws-bedrock), CAMEL-23532 (camel-vertx-websocket / camel-atmosphere-websocket / camel-iggy), and CAMEL-23576 (camel-jira). The Java field name is unchanged so routes referencing the constant symbolically continue to work; routes using the literal string value must be updated (documented in the 4.21 upgrade guide). MiloConstants.HEADER_NODE_IDS was already Camel-prefixed (CamelMiloNodeIds) and is unchanged. Updates the two tests (WriteClientTest, CallClientTest) that set the header by its literal value. The generated Endpoint DSL header accessor await() on MiloClientHeaderNameBuilder has been renamed to miloAwait(). Tracker: CAMEL-23577 Reported by Claude Code on behalf of Andrea Cosentino Signed-off-by: Andrea Cosentino <ancosen@gmail.com> * CAMEL-23590: address review - update milo-client doc example to new header value Updates the route example in components/camel-milo/src/main/docs/milo-client-component.adoc that quoted the old literal header value "await" to use the new "CamelMiloAwait" value introduced by this PR. Addresses Guillaume Nodet's review on apache#23474. Reported by Claude Code on behalf of Andrea Cosentino Signed-off-by: Andrea Cosentino <ancosen@gmail.com> --------- Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
davsclaus
approved these changes
May 25, 2026
gnodet
approved these changes
May 25, 2026
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Clean backport of the camel-milo HEADER_AWAIT rename to 4.18.x. Header value changed from await to CamelMiloAwait, Java constant, catalog JSON, Endpoint DSL accessor, tests, and upgrade guide all updated consistently. Doc example in milo-client-component.adoc also fixed.
LGTM.
Claude Code on behalf of Guillaume Nodet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #23474
Cherry-pick of #23474 onto
camel-4.18.x.09d38da3ef2camel-4.18.xcamel-milodoes not exist on the 4.14 line (the component was removed and later reinstated).Manual adjustments during cherry-pick
camel-4x-upgrade-guide-4_21.adoc(does notexist on this branch) to
camel-4x-upgrade-guide-4_18.adoc, preserving thefull content including the
- potential breaking changeflag. The matching4_18.adocentry onmainshould be synced in a follow-up PR perCLAUDE.md's backport upgrade-guide policy.
4.18.x's generators (full reactor build,
-DskipTests).Change summary
Renames
MiloConstants.HEADER_AWAITheader string value from"await"to"CamelMiloAwait". The Java field name is unchanged so routes referencing theconstant symbolically continue to work; routes using the literal string value
must be updated. Also updates the two tests that set the header by literal
value, and the generated endpoint DSL header accessor (
await()→miloAwait()).MiloConstants.HEADER_NODE_IDSwas alreadyCamel-prefixed and is unchanged.JIRA: https://issues.apache.org/jira/browse/CAMEL-23590
Backport prepared by Claude Code on behalf of Andrea Cosentino.