Skip to content

camel-openai: close OpenAI client on endpoint stop to prevent OkHttp thread leak #23531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Croway merged 1 commit into from
May 26, 2026
+1 −0
Merged

camel-openai: close OpenAI client on endpoint stop to prevent OkHttp thread leak #23531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...camel-ai/camel-openai/src/main/java/org/apache/camel/component/openai/OpenAIEndpoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ protected void doStop() throws Exception {
returnDirectTools.clear();
}
if (client != null) {
client.close();
Copy link
Copy Markdown
Contributor

@apupier apupier May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we enclose in a try catch as it is done for the mcp clients?

Copy link
Copy Markdown
Contributor Author

@Croway Croway May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Closes this client, relinquishing any underlying resources.
This is purposefully not inherited from AutoCloseable because the client is long-lived and usually should not be synchronously closed via try-with-resources.

this is from the .close() java doc, should be safe without a try catch

client = null;
}
super.doStop();
Expand Down