[backport camel-4.18.x] CAMEL-23581: camel-elasticsearch + camel-opensearch - align Exchange header constant names with Camel naming convention#23538
Merged
oscerd merged 1 commit intoMay 27, 2026
Conversation
davsclaus
approved these changes
May 26, 2026
gnodet
approved these changes
May 26, 2026
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Standard header rename backport for camel-elasticsearch and camel-opensearch to 4.18.x. Renames headers from short names (e.g., operation, indexId, indexName) to Camel-prefixed names (e.g., CamelElasticsearchOperation, CamelElasticsearchIndexId). Both components follow the same pattern. Upgrade guide entry included. Bulk of the diff is generated catalog metadata.
LGTM.
Fully automatic review from Claude Code
oscerd
force-pushed
the
backport/23442-to-camel-4.18.x
branch
4 times, most recently
from
4e17268 to
4f0cef6
Compare
…header constant names with Camel naming convention (apache#23442) Renames the Exchange header string values in ElasticsearchConstants and OpensearchConstants from non-Camel prefixed values (operation, indexId, indexName, documentClass, waitForActiveShards, scrollKeepAliveMs, useScroll, size, from, enableDocumentOnlyMode) to CamelElasticsearch* / CamelOpensearch*, following the convention used across the rest of the Camel component catalog and matching the pattern established in CAMEL-23526 (camel-cxf), CAMEL-23522 (camel-mail), CAMEL-23461 (camel-aws-bedrock), CAMEL-23532 (camel-vertx-websocket / camel-atmosphere-websocket / camel-iggy), and CAMEL-23576 (camel-jira). The Java field names (PARAM_OPERATION, PARAM_INDEX_ID, PARAM_INDEX_NAME, PARAM_DOCUMENT_CLASS, PARAM_WAIT_FOR_ACTIVE_SHARDS, PARAM_SCROLL_KEEP_ALIVE_MS, PARAM_SCROLL, PARAM_SIZE, PARAM_FROM, PARAM_DOCUMENT_MODE) are unchanged so routes referencing the constants symbolically continue to work; routes using the literal string values must be updated (documented in the 4.21 upgrade guide). The already-Camel-prefixed PROPERTY_SCROLL_ES_QUERY_COUNT and PROPERTY_SCROLL_OPENSEARCH_QUERY_COUNT constants are unchanged. The generated Endpoint DSL header accessors on ElasticsearchHeaderNameBuilder and OpensearchHeaderNameBuilder have been renamed accordingly (operation() -> elasticsearchOperation() / opensearchOperation(), indexId() -> elasticsearchIndexId() / opensearchIndexId(), etc.). All existing tests use symbolic constant references and continue to pass without changes. Tracker: CAMEL-23577 Reported by Claude Code on behalf of Andrea Cosentino Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
oscerd
force-pushed
the
backport/23442-to-camel-4.18.x
branch
from
4f0cef6 to
bebf70f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #23442 to
camel-4.18.x.Cherry-pick of merge commit
70d9e92ee03with one adaptation: the originalPR's upgrade-guide entry was added to
camel-4x-upgrade-guide-4_21.adoc,which does not exist on the 4.18.x maintenance branch. Per the project's
backport policy the same content has been added to
camel-4x-upgrade-guide-4_18.adocinstead.Summary
Renames the
PARAM_*Exchange header string values inElasticsearchConstantsand
OpensearchConstantsthat were not in theCamelnamespace toCamelElasticsearch*/CamelOpensearch*respectively.10 constants renamed in
ElasticsearchConstants(PARAM_OPERATION,PARAM_INDEX_ID,PARAM_INDEX_NAME,PARAM_DOCUMENT_CLASS,PARAM_WAIT_FOR_ACTIVE_SHARDS,PARAM_SCROLL_KEEP_ALIVE_MS,PARAM_SCROLL,PARAM_SIZE,PARAM_FROM,PARAM_DOCUMENT_MODE); 9 constants renamed inOpensearchConstants(same minusPARAM_DOCUMENT_MODE, which only exists inElasticsearchConstants).The Java field names are unchanged so routes referencing the constants
symbolically continue to work; routes using the literal string values must be
updated.
PROPERTY_SCROLL_ES_QUERY_COUNT/PROPERTY_SCROLL_OPENSEARCH_QUERY_COUNTwere alreadyCamel-prefixed andare unchanged.
DSL accessors renamed accordingly:
operation()→elasticsearchOperation()/
opensearchOperation(),indexId()→elasticsearchIndexId()/opensearchIndexId(), etc.Test plan
mvn testincomponents/camel-elasticsearchon 4.18.x — BUILD SUCCESSmvn testincomponents/camel-opensearchon 4.18.x — BUILD SUCCESSrename described above (no merge marker shipped)
=== camel-elasticsearch / camel-opensearch - potential breaking changein
camel-4x-upgrade-guide-4_18.adocTracker: CAMEL-23577
Reported by Claude Code on behalf of Andrea Cosentino