CAMEL-23615: camel-tui - Fix unsafe type casts and unguarded parsing#23547
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet
approved these changes
May 27, 2026
Contributor
gnodet
left a comment
There was a problem hiding this comment.
Good defensive coding fixes for the TUI:
- Wrapping
Long.parseLong(ctx.selectedPid)in try-catch forNumberFormatException— prevents crash on unexpected PID values. - Replacing unsafe
(Boolean) json.get("done")/(Boolean) json.get("failed")casts withBoolean.TRUE.equals(...)— avoidsClassCastExceptionif the JSON value isn't a Boolean object. - Same fix for
cj.get("polling")inparseIntegration.
All three changes follow the same pattern: replacing unsafe assumptions about runtime types with null-safe, cast-safe alternatives.
LGTM.
Fully automatic review from Claude Code
Contributor
|
🧪 CI tested the following changed modules:
All tested modules (2 modules)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(Boolean)cast from JSON forpollingfield — useBoolean.TRUE.equals()instead(Boolean)casts fordone/failedfields in history entry parsingLong.parseLong(ctx.selectedPid)with try-catch on tab switch to historyTest plan
Claude Code on behalf of Claus Ibsen