chore: agent quality expectations#23579
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
@davsclaus this is after the conversation we had in last meeting. I hope it helps to increase the level of quality of contributions. |
|
ℹ️ CI did not run targeted module tests. |
|
I think this is a good idea, but a bit too broad - as even SCAs can have a lot of false positives. I would try to narrow this a bit, towards more specific and recurrent anti patterns. |
|
I would rephrase this, because the quality could degrade if the agent follow this literally. Maybe we could try for a while and eventually rollback. |
oscerd
left a comment
There was a problem hiding this comment.
I think we could try, but if we notice the quality decrease or weird things, we should revert.
b7bce84 to
8e9e2d3
Compare
|
I've provided a more clear list of main quality metrics to take in account. In general, this is likely going to be a try/error approach as we need to fine tune based on the concrete output we'll be seeing coming out |
gnodet
left a comment
There was a problem hiding this comment.
Good addition to AGENTS.md — explicitly sets quality expectations for agent contributions regarding static analysis (code smells, CWE, OWASP, deprecated code usage). This complements the existing code quality rules and makes the expectations clear for automated contributors.
LGTM.
Fully automatic review from Claude Code
|
LGTM |
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.