[backport camel-4.18.x] CAMEL-23646: Fix inverted BackgroundTask return values in sjms, pgevent and master#23641
Merged
Croway merged 1 commit intoMay 29, 2026
Conversation
…nt and master The BackOff to BackgroundTask migration (CAMEL-22206) preserved the callback return values verbatim, but the two APIs have opposite boolean semantics: BackOff returns false to stop, BackgroundTask returns true to stop. This caused infinite retry loops after successful recovery in all three components.
davsclaus
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #23639
Cherry-pick of #23639 onto
camel-4.18.x.Original PR: #23639 - CAMEL-23646: Fix inverted BackgroundTask return values in sjms, pgevent and master
Original author: @Croway
Target branch:
camel-4.18.xOriginal description
The
BackOff→BackgroundTaskmigration (CAMEL-22206) preserved callback return values verbatim, but the two APIs have opposite boolean semantics:BackOffreturnsfalseto stop,BackgroundTaskreturnstrueto stop. This caused infinite retry loops after successful recovery in three components.camel-sjms/sjms2 — after a transient JMS connection interruption (reported with Oracle AQ), the consumer enters an infinite recovery loop. Each iteration destroys the working connection via
refreshConnection()whileinitConsumers()skips re-creation (consumers != null), leaving consumers attached to closed sessions. Message consumption is permanently blocked.camel-pgevent — after successful PostgreSQL reconnection, the task keeps calling
initConnection()everyreconnectDelay, leaking connections and duplicating notification listeners.camel-master — after the delegated consumer starts, the task keeps calling
ServiceHelper.startService()until budget exhaustion (default 10 iterations). Can revive a consumer after leadership loss.Claude Code on behalf of Federico Mariani