CAMEL-19551: add assertions to JPA transacted tests#23814
Merged
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
All tested modules (8 modules)
|
oscerd
approved these changes
Jun 7, 2026
davsclaus
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses CAMEL-19551 by adding explicit assertions to JPA transacted tests that previously executed routes without verifying any observable outcome.
The following tests did not contain assertions:
Each test now verifies that the expected entities are persisted in the database after route execution using
assertEntityInDB(2).This improves test clarity and aligns the tests with the goal of CAMEL-19551, ensuring tests contain meaningful assertions rather than only executing code paths.
This is a test-only change and does not modify component behavior.
Validation:
Ran:
./mvnw -pl components/camel-jpa -Dtest=JpaTransactedTest testResults:
Target
mainbranch)Tracking
Apache Camel coding standards and style
I checked that each commit in the pull request has a meaningful subject line and body.
I ran the relevant module tests locally and verified they pass.