Skip to content

fix: add missing .borders(Borders.ALL) to restore TUI pane borders #24280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gnodet wants to merge 3 commits into
base: main
Choose a base branch
from
+3,822 −133
Draft

fix: add missing .borders(Borders.ALL) to restore TUI pane borders #24280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95c7297
chore: add comprehensive test coverage for camel-jbang-plugin-tui
gnodet Jun 28, 2026
37d2846
chore: add higher-level rendering tests for TUI tabs
gnodet Jun 28, 2026
c72d8ff
fix: add missing .borders(Borders.ALL) to restore TUI pane borders
gnodet Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions ...g-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/ActionsPopup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
import dev.tamboui.widgets.Clear;
import dev.tamboui.widgets.block.Block;
import dev.tamboui.widgets.block.BorderType;
import dev.tamboui.widgets.block.Borders;
import dev.tamboui.widgets.block.Title;
import dev.tamboui.widgets.input.TextInput;
import dev.tamboui.widgets.input.TextInputState;
Expand Down Expand Up @@ -818,7 +819,7 @@ private void renderActionsMenu(Frame frame, Rect area) {
.highlightSymbol("")
.scrollMode(ScrollMode.NONE)
.block(Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.title(" Actions ")
.build())
.build();
Expand All @@ -844,7 +845,7 @@ private void renderExampleBrowser(Frame frame, Rect area) {
.highlightSymbol("")
.scrollMode(ScrollMode.AUTO_SCROLL)
.block(Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.title(" Run an Example (" + exampleCatalog.size() + ") ")
.build())
.build();
Expand Down Expand Up @@ -910,7 +911,7 @@ private void renderDocViewer(Frame frame, Rect area) {
title = Title.from(" " + docTitle + " ");
}
Block block = Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.title(title)
.build();
if (docLines != null) {
Expand Down Expand Up @@ -960,7 +961,7 @@ private void renderDocPicker(Frame frame, Rect area) {
.highlightSymbol("")
.scrollMode(ScrollMode.AUTO_SCROLL)
.block(Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.title(" Show Integration Doc ")
.build())
.build();
Expand Down Expand Up @@ -1331,7 +1332,7 @@ private void renderFolderInput(Frame frame, Rect area) {
frame.renderWidget(Clear.INSTANCE, popup);

Block block = Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.title(" Run from folder ")
.build();
frame.renderWidget(block, popup);
Expand Down Expand Up @@ -1782,7 +1783,7 @@ private void renderInfraBrowser(Frame frame, Rect area) {
.highlightSymbol("")
.scrollMode(ScrollMode.AUTO_SCROLL)
.block(Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.title(" Run Dev/Infra Service (" + available + "/" + infraCatalog.size() + ") ")
.build())
.build();
Expand All @@ -1805,7 +1806,7 @@ private void renderInfraPortDialog(Frame frame, Rect area) {
frame.renderWidget(Clear.INSTANCE, popup);

Block block = Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.title(" Run " + selectedInfraService.alias + " ")
.build();
frame.renderWidget(block, popup);
Expand Down
12 changes: 7 additions & 5 deletions ...jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/BeansTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import dev.tamboui.tui.event.KeyEvent;
import dev.tamboui.widgets.block.Block;
import dev.tamboui.widgets.block.BorderType;
import dev.tamboui.widgets.block.Borders;
import dev.tamboui.widgets.paragraph.Paragraph;
import dev.tamboui.widgets.table.Cell;
import dev.tamboui.widgets.table.Row;
Expand Down Expand Up @@ -185,7 +186,7 @@ public void render(Frame frame, Rect area) {
frame.renderWidget(
Paragraph.builder()
.text(Text.from(Line.from(Span.styled(" Loading beans...", Style.EMPTY.dim()))))
.block(Block.builder().borderType(BorderType.ROUNDED).title(" Beans ").build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(" Beans ").build())
.build(),
area);
return;
Expand Down Expand Up @@ -240,7 +241,7 @@ private void renderTable(Frame frame, Rect area, List<BeanData> visible) {
Constraint.fill())
.highlightStyle(Style.EMPTY.fg(Color.WHITE).bold().onBlue())
.highlightSpacing(Table.HighlightSpacing.ALWAYS)
.block(Block.builder().borderType(BorderType.ROUNDED).title(title).build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(title).build())
.build();

frame.renderStatefulWidget(table, area, tableState);
Expand All @@ -252,7 +253,8 @@ private void renderDetail(Frame frame, Rect area, List<BeanData> visible) {
frame.renderWidget(
Paragraph.builder()
.text(Text.from(Line.from(Span.styled(" Select a bean", Style.EMPTY.dim()))))
.block(Block.builder().borderType(BorderType.ROUNDED).title(" Properties ").build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(" Properties ")
.build())
.build(),
area);
return;
Expand All @@ -265,7 +267,7 @@ private void renderDetail(Frame frame, Rect area, List<BeanData> visible) {
frame.renderWidget(
Paragraph.builder()
.text(Text.from(Line.from(Span.styled(" No properties", Style.EMPTY.dim()))))
.block(Block.builder().borderType(BorderType.ROUNDED).title(title).build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(title).build())
.build(),
area);
return;
Expand Down Expand Up @@ -297,7 +299,7 @@ private void renderDetail(Frame frame, Rect area, List<BeanData> visible) {
frame.renderWidget(
Paragraph.builder()
.text(Text.from(lines))
.block(Block.builder().borderType(BorderType.ROUNDED).title(title).build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(title).build())
.build(),
area);
}
Expand Down
15 changes: 9 additions & 6 deletions ...bang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/BrowseTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import dev.tamboui.tui.event.KeyEvent;
import dev.tamboui.widgets.block.Block;
import dev.tamboui.widgets.block.BorderType;
import dev.tamboui.widgets.block.Borders;
import dev.tamboui.widgets.paragraph.Paragraph;
import dev.tamboui.widgets.table.Cell;
import dev.tamboui.widgets.table.Row;
Expand Down Expand Up @@ -248,7 +249,8 @@ public void render(Frame frame, Rect area) {
frame.renderWidget(
Paragraph.builder()
.text(Text.from(Line.from(Span.styled(" Loading browse endpoints...", Style.EMPTY.dim()))))
.block(Block.builder().borderType(BorderType.ROUNDED).title(" Browse ").build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(" Browse ")
.build())
.build(),
area);
return;
Expand Down Expand Up @@ -296,7 +298,7 @@ private void renderEndpoints(Frame frame, Rect area) {
Constraint.length(10))
.highlightStyle(Style.EMPTY.fg(Color.WHITE).bold().onBlue())
.highlightSpacing(Table.HighlightSpacing.ALWAYS)
.block(Block.builder().borderType(BorderType.ROUNDED).title(title).build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(title).build())
.build();

frame.renderStatefulWidget(table, area, endpointTableState);
Expand All @@ -308,7 +310,7 @@ private void renderMessages(Frame frame, Rect area) {
frame.renderWidget(
Paragraph.builder()
.text(Text.from(Line.from(Span.styled(" Loading messages...", Style.EMPTY.dim()))))
.block(Block.builder().borderType(BorderType.ROUNDED).title(title).build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(title).build())
.build(),
area);
return;
Expand Down Expand Up @@ -349,7 +351,7 @@ private void renderMessages(Frame frame, Rect area) {
Constraint.fill())
.highlightStyle(Style.EMPTY.fg(Color.WHITE).bold().onBlue())
.highlightSpacing(Table.HighlightSpacing.ALWAYS)
.block(Block.builder().borderType(BorderType.ROUNDED).title(title).build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(title).build())
.build();

frame.renderStatefulWidget(table, area, messageTableState);
Expand All @@ -361,7 +363,8 @@ private void renderDetail(Frame frame, Rect area) {
frame.renderWidget(
Paragraph.builder()
.text(Text.from(Line.from(Span.styled(" Select a message", Style.EMPTY.dim()))))
.block(Block.builder().borderType(BorderType.ROUNDED).title(" Message ").build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(" Message ")
.build())
.build(),
area);
return;
Expand Down Expand Up @@ -432,7 +435,7 @@ private void renderDetail(Frame frame, Rect area) {
frame.renderWidget(
Paragraph.builder()
.text(Text.from(visible))
.block(Block.builder().borderType(BorderType.ROUNDED).title(title).build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(title).build())
.build(),
chunks.get(1));
}
Expand Down
10 changes: 5 additions & 5 deletions ...lugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/CamelCatalogTui.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ private void renderHeader(Frame frame, Rect area) {
Style.EMPTY.fg(Color.CYAN)));

Block headerBlock = Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.title(" Apache Camel ")
.build();

Expand Down Expand Up @@ -468,7 +468,7 @@ private void renderComponentList(Frame frame, Rect area) {
.highlightStyle(Style.EMPTY.fg(Color.WHITE).bold().onBlue())
.highlightSpacing(Table.HighlightSpacing.ALWAYS)
.block(Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.borderStyle(borderStyle)
.title(listTitle)
.build())
Expand All @@ -494,7 +494,7 @@ private void renderOptionsTable(Frame frame, Rect area) {
.text(Text.from(Line.from(
Span.styled(emptyMsg, Style.EMPTY.dim()))))
.block(Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.borderStyle(borderStyle)
.title(optTitle)
.build())
Expand Down Expand Up @@ -527,7 +527,7 @@ private void renderOptionsTable(Frame frame, Rect area) {
.highlightStyle(Style.EMPTY.fg(Color.WHITE).bold().onBlue())
.highlightSpacing(Table.HighlightSpacing.ALWAYS)
.block(Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.borderStyle(borderStyle)
.title(optTitle)
.build())
Expand Down Expand Up @@ -617,7 +617,7 @@ private void renderDescription(Frame frame, Rect area) {
.overflow(Overflow.WRAP_WORD)
.scroll(descriptionScroll)
.block(Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.title(title)
.build())
.build(),
Expand Down
7 changes: 4 additions & 3 deletions ...g-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/CamelMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
import dev.tamboui.widgets.Clear;
import dev.tamboui.widgets.block.Block;
import dev.tamboui.widgets.block.BorderType;
import dev.tamboui.widgets.block.Borders;
import dev.tamboui.widgets.block.Title;
import dev.tamboui.widgets.list.ListItem;
import dev.tamboui.widgets.list.ListState;
Expand Down Expand Up @@ -1276,7 +1277,7 @@ private void renderMorePopup(Frame frame, Rect area) {
.highlightSymbol("")
.scrollMode(ScrollMode.NONE)
.block(Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.title(Title.from(Line.from(Span.styled(" More Tabs ", Style.EMPTY.fg(Color.YELLOW).bold()))))
.build())
.build();
Expand Down Expand Up @@ -1324,7 +1325,7 @@ private void renderSwitchPopup(Frame frame, Rect area) {
.highlightSymbol("")
.scrollMode(ScrollMode.NONE)
.block(Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.title(Title.from(Line.from(Span.styled(" Switch Integration ", Style.EMPTY.fg(Color.YELLOW).bold()))))
.build())
.build();
Expand Down Expand Up @@ -1607,7 +1608,7 @@ private void renderKillConfirm(Frame frame, Rect area) {

frame.renderWidget(Clear.INSTANCE, popup);
Block block = Block.builder()
.borderType(BorderType.ROUNDED)
.borderType(BorderType.ROUNDED).borders(Borders.ALL)
.borderStyle(Style.EMPTY.fg(Color.LIGHT_RED))
.title(" Confirm Kill ")
.build();
Expand Down
11 changes: 6 additions & 5 deletions ...gin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/CircuitBreakerTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import dev.tamboui.tui.event.KeyEvent;
import dev.tamboui.widgets.block.Block;
import dev.tamboui.widgets.block.BorderType;
import dev.tamboui.widgets.block.Borders;
import dev.tamboui.widgets.block.Title;
import dev.tamboui.widgets.paragraph.Paragraph;
import dev.tamboui.widgets.sparkline.DualSparkline;
Expand Down Expand Up @@ -193,7 +194,7 @@ public void render(Frame frame, Rect area) {
Constraint.fill())
.highlightStyle(Style.EMPTY.fg(Color.WHITE).bold().onBlue())
.highlightSpacing(Table.HighlightSpacing.ALWAYS)
.block(Block.builder().borderType(BorderType.ROUNDED).title(" Circuit Breaker ").build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(" Circuit Breaker ").build())
.build();

frame.renderStatefulWidget(table, chunks.get(0), tableState);
Expand Down Expand Up @@ -314,7 +315,7 @@ private void renderStateDiagram(Frame frame, Rect area, CircuitBreakerInfo cb) {

frame.renderWidget(Paragraph.builder()
.text(Text.from(lines))
.block(Block.builder().borderType(BorderType.ROUNDED).title(title).build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(title).build())
.build(), area);
}

Expand Down Expand Up @@ -346,7 +347,7 @@ private void renderChart(Frame frame, Rect area, CircuitBreakerInfo cb, String p
Span.styled("░".repeat(empty), Style.EMPTY.dim()));
frame.renderWidget(Paragraph.builder()
.text(Text.from(barLine))
.block(Block.builder().borderType(BorderType.ROUNDED).title(" Failure Rate ").build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(" Failure Rate ").build())
.build(), vSplit.get(0));

LinkedList<Long> successHist = cbSuccessHistory.get(key);
Expand Down Expand Up @@ -384,7 +385,7 @@ private void renderChart(Frame frame, Rect area, CircuitBreakerInfo cb, String p
.bottomStyle(Style.EMPTY.fg(Color.LIGHT_RED))
.showYAxis(true)
.xLabels("-60s", "-45s", "-30s", "-15s", "now")
.block(Block.builder().borderType(BorderType.ROUNDED)
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL)
.title(Title.from(chartTitle)).build())
.build(), vSplit.get(1));

Expand All @@ -408,7 +409,7 @@ private void renderChart(Frame frame, Rect area, CircuitBreakerInfo cb, String p
Span.styled("fail:", dim), Span.raw(" " + lastFail));
frame.renderWidget(Paragraph.builder()
.text(Text.from(Line.from(Span.raw("")), metricsLine1, metricsLine2))
.block(Block.builder().borderType(BorderType.ROUNDED).build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).build())
.build(), vSplit.get(2));
}

Expand Down
7 changes: 4 additions & 3 deletions ...g-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/ClasspathTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import dev.tamboui.tui.event.KeyEvent;
import dev.tamboui.widgets.block.Block;
import dev.tamboui.widgets.block.BorderType;
import dev.tamboui.widgets.block.Borders;
import dev.tamboui.widgets.list.ListItem;
import dev.tamboui.widgets.list.ListState;
import dev.tamboui.widgets.list.ListWidget;
Expand Down Expand Up @@ -148,7 +149,7 @@ public void render(Frame frame, Rect area) {
frame.renderWidget(
Paragraph.builder()
.text(Text.from(Line.from(Span.styled(" Loading classpath...", Style.EMPTY.dim()))))
.block(Block.builder().borderType(BorderType.ROUNDED)
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL)
.title(" Classpath ").build())
.build(),
area);
Expand All @@ -160,7 +161,7 @@ public void render(Frame frame, Rect area) {
Paragraph.builder()
.text(Text.from(Line.from(
Span.styled(" " + errorMessage, Style.EMPTY.fg(Color.LIGHT_RED)))))
.block(Block.builder().borderType(BorderType.ROUNDED)
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL)
.title(" Classpath ").build())
.build(),
area);
Expand Down Expand Up @@ -197,7 +198,7 @@ public void render(Frame frame, Rect area) {
.highlightStyle(Style.EMPTY.fg(Color.WHITE).bold().onBlue())
.highlightSymbol("")
.scrollMode(ScrollMode.AUTO_SCROLL)
.block(Block.builder().borderType(BorderType.ROUNDED).title(title).build())
.block(Block.builder().borderType(BorderType.ROUNDED).borders(Borders.ALL).title(title).build())
.build();
frame.renderStatefulWidget(list, area, listState);
}
Expand Down
Loading
Loading