CAMEL-23912: Address review feedback on ThemeTest fix#24482
Merged
Conversation
- Handle null classloader from Theme.class.getClassLoader() to avoid NPE when the class is bootstrap-loaded (Copilot feedback) - Soften javadoc wording: classloader access is not "guaranteed", it falls back to TCCL when the primary lookup returns null (ammachado) - Revert ConcurrentHashMap to HashMap since all CACHE access is already inside synchronized methods (ammachado) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
davsclaus
approved these changes
Jul 7, 2026
davsclaus
approved these changes
Jul 7, 2026
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 2 tested, 1 compile-only — current: 2 all testedMaveniverse Scalpel detected 3 affected modules (current approach: 2).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Code on behalf of gnodet
Summary
Follow-up to #24475 — addresses review feedback from Copilot and @ammachado that landed after the original PR was merged.
Changes:
Theme.class.getClassLoader()can legally returnnullfor bootstrap-loaded classes. Now null-checked before callinggetResourceAsStream(), falling through to the TCCL fallback instead of throwing an NPE.ConcurrentHashMaptoHashMap(@ammachado suggestion Camel ssh component CAMEL-4713 #2): AllCACHEaccess is already insidesynchronizedmethods, so the concurrent map added no real safety — just a misleading signal.Test plan
ThemeTesttests pass.mvn formatter:format impsort:sortproduces no diff.🤖 Generated with Claude Code