[CAMEL-13026] Add 'CsvMarshallerFactory' and corresponding tests

[ribeaud]

Hi @onderson. Here we are... Cheers,
christian

[onderson]

You can use objecthelper.notnull to enforce non-null values

[ribeaud]

Thanks for the hint. There is java.util.Objects.requireNonNull since Java 1.7 as well. Personally, I would prefer assertions for potential programmatic errors like here (if the value is null, then the programmer did something wrong - not related to the environment or to the machine).
However, I am going to follow your suggestion (for consistency) and adapt the PR.

[onderson]

Minor comment(that might be applicable for a couple of more places), you can use ObjectHelper.notNull.
Apart from that, LGTM.

[davsclaus]

When adding new options to a data format its a little more complicated as you need to add the options to CsvDataFormat in camel-core too.

[ribeaud]

When adding new options to a data format its a little more complicated as you need to add the options to CsvDataFormat in camel-core too.

OK, what should we do then?

[dmvolod]

@ribeaud you should to change this file also https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/model/dataformat/CsvDataFormat.java
Please use other commits as example.

[davsclaus]

Yeah as @dmvolod says we need to add the option to the model class in camel-core, and also add documentation to the option (if missing).

[ribeaud]

Good morning,

@dmvolod: Which commits are you referencing to?
@davsclaus Are you talking about csv-dataformat.adoc?

I am going to update the PR in the next hour... Regards,
christian

[dmvolod]

@ribeaud you can look at this commit for example 7b36d71#diff-3e53038b6f7e711448d3c517b7f36109

[ribeaud]

Hi,

Done. On my local environment mvn clean install -Psourcecheck resp. mvn clean install -Pfastinstall at camel level are both failing. And I do NOT currently have the time to dig deeper on that.

I got a bit lost regarding the documentation: should I update both csv-dataformat.adoc? Is one of them automatically generated?

Anyway, have a look and let me know. Thanks and cheers and have a nice one,

christian.

[dmvolod]

@ribeaud run it locally and all tests passed successfully, looks like problems with your env.
You don't need to update *.adoc in /docs folder manually, it will sync automatically with mvn install on /docs

[dmvolod]

@davsclaus , @onderson and @oscerd are you agree to merge it?

[davsclaus]

The documentation for the option could be better - dont say set or get X, but say something like to use a custom csv formatter factory for implementing your own formatter for more advanced use-cases. And likely when we regen the code it will be updated. But that is not a biggie. The option should also be labelled as an advanced option.

[dmvolod]

Thanks @davsclaus , I will merge it and polish as well.