CAMEL-13601 - Fix camel-jira client close and add logging#2952
CAMEL-13601 - Fix camel-jira client close and add logging#2952claudio4j wants to merge 1 commit intoapache:masterfrom
Conversation
| super(endpoint, processor); | ||
| LOG.info("JIRA NewCommentsConsumer: Indexing current issue comments..."); | ||
| getComments(false); | ||
| LOG.info("JIRA NewCommentsConsumer: Indexing current issue comments."); |
There was a problem hiding this comment.
We should move such tasks to doStart and not in constructors
There was a problem hiding this comment.
Done. Thanks for the review.
| // Ignore maxResults if it's <= 0. | ||
| protected List<Issue> getIssues(String jql, int start, int maxPerQuery, int maxResults) { | ||
| LOG.info("Indexing current JIRA issues..."); | ||
| LOG.info("Start indexing current JIRA issues..."); |
There was a problem hiding this comment.
Do we really need this INFO logging noise? If this method is invoked frequently you get spammed with logs. Can we lower this to DEBUG
There was a problem hiding this comment.
Done. Thanks for the review.
| Stack<Comment> newComments = new Stack<>(); | ||
| @SuppressWarnings("ConstantConditions") | ||
| private List<Comment> getComments() { | ||
| LOG.info("Start: Jira NewCommentsConsumer: retrieving issue comments. Last comment id: {}", lastCommentId); |
There was a problem hiding this comment.
Do we really need this INFO logging noise? If this method is invoked frequently you get spammed with logs. Can we lower this to DEBUG
oscerd
left a comment
oscerd
left a comment
There was a problem hiding this comment.
I don't know why changing the guava version
| <jgroups-raft-leveldbjni-version>1.8</jgroups-raft-leveldbjni-version> | ||
| <jgroups-raft-mapdb-version>1.0.8</jgroups-raft-mapdb-version> | ||
| <jira-guava-version>26.0-jre</jira-guava-version> | ||
| <jira-guava-version>20.0</jira-guava-version> |
There was a problem hiding this comment.
Why this one was changed ? Just curiosity
There was a problem hiding this comment.
The jira rest java client (JRJC) 5.1.0 doesn't define a guava version. As previously I used JRJC 5.1.2, its pom.xml defined the guava version, but when I changed to 5.1.0, I forgot to add the guava version.
https://bitbucket.org/atlassian/jira-rest-java-client/src/jira-rest-java-client-parent-5.1.0/pom.xml
oscerd
left a comment
oscerd
left a comment
There was a problem hiding this comment.
Probably all the logging stuff can be at DEBUG level
|
Done, thanks for the review. |
|
What's the reason for Guava version downgrade? |
|
Merged on master |
|
Thanks |
3 participants
https://issues.apache.org/jira/browse/CAMEL-13601