CAMEL-13962: keep track of brackets that belong to a method in order …#3165
Closed
mpaetzold wants to merge 2 commits intoapache:masterfrom
mpaetzold:CAMEL-13962
Closed
CAMEL-13962: keep track of brackets that belong to a method in order …#3165mpaetzold wants to merge 2 commits intoapache:masterfrom mpaetzold:CAMEL-13962
mpaetzold wants to merge 2 commits intoapache:masterfrom
mpaetzold:CAMEL-13962
Conversation
…to prevent false method splitting
omarsmak
requested changes
Sep 12, 2019
Member
omarsmak
left a comment
omarsmak
left a comment
There was a problem hiding this comment.
Thanks @mpaetzold for the PR! Just some nits from my side, please see below. BTW, for the future, you can run mvn -Psourcecheck clean install to verify the checkstyle of your code to fix these small nits
| @@ -0,0 +1,26 @@ | |||
| package org.apache.camel.util; | |||
Member
There was a problem hiding this comment.
nit: the licence header needs to be added here
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
|
|
||
| import java.util.List; |
Member
There was a problem hiding this comment.
nit: the order needs to be rearranged
|
|
||
| String last = methods.isEmpty() ? null : methods.get(methods.size() - 1); | ||
| if (parenthesisBracket && last != null) { | ||
| if (parenthesisBracketCnt>0 && last != null) { |
Member
There was a problem hiding this comment.
nit: there should be whitespace between >
oscerd
requested changes
Sep 12, 2019
Contributor
oscerd
left a comment
oscerd
left a comment
There was a problem hiding this comment.
Except the code style it seems to be ok. Did you run the all the camel core tests?
Contributor
Author
|
I fixed the code style issues. And yes I ran the core tests. |
oscerd
approved these changes
Sep 12, 2019
omarsmak
approved these changes
Sep 12, 2019
davsclaus
approved these changes
Sep 14, 2019
Contributor
|
Merged on master. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to prevent false method splitting