CAMEL-14008 changed HTTPConnection to a HttpConnectionPool#3188
Closed
Braus wants to merge 1 commit intoapache:masterfrom
Braus:master
Closed
CAMEL-14008 changed HTTPConnection to a HttpConnectionPool#3188Braus wants to merge 1 commit intoapache:masterfrom Braus:master
Braus wants to merge 1 commit intoapache:masterfrom
Braus:master
Conversation
…elp of Maurice Betzel
oscerd
requested changes
Sep 24, 2019
Contributor
oscerd
left a comment
oscerd
left a comment
There was a problem hiding this comment.
Minor stuff, I'd like to have the feedback of @davsclaus and @punkhorn
| import org.apache.http.protocol.RequestUserAgent; | ||
| import org.apache.http.util.Args; | ||
|
|
||
| import java.io.IOException; |
Contributor
There was a problem hiding this comment.
Please run the build with sourcecheck profile enabled and check the warnings. The imports order is wrong.
Author
There was a problem hiding this comment.
Hi @oscerd,
Where can I find the sourcecheck profile? I'm using Intellij
Contributor
There was a problem hiding this comment.
Hello,
You just need to run the module build with -Psourcecheck. You'll see some warnings at the beginning.
| HttpClientConnection httpClientConnection = null; | ||
| try { | ||
| httpClientConnection = connectionRequest.get(10, TimeUnit.SECONDS); | ||
| } catch (InterruptedException e) { |
| String entityContentTransferEncoding = null; | ||
| for (Header header : headers) { | ||
| if (header.getName().equalsIgnoreCase(AS2Header.CONTENT_TYPE)) { | ||
| switch (header.getName()) { |
Contributor
There was a problem hiding this comment.
Sourcecheck profile enabled here too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the help of @Maurice-Betzel