CAMEL-13988: Add Map data input support to Protobuf dataformat#3206
Merged
davsclaus merged 2 commits intoapache:masterfrom Sep 30, 2019
omarsmak:CAMEL-13988
Merged
CAMEL-13988: Add Map data input support to Protobuf dataformat#3206davsclaus merged 2 commits intoapache:masterfrom omarsmak:CAMEL-13988
davsclaus merged 2 commits intoapache:masterfrom
omarsmak:CAMEL-13988
Conversation
Signed-off-by: Omar Al-Safi <omarsmak@gmail.com>
Signed-off-by: Omar Al-Safi <omarsmak@gmail.com>
oscerd
requested changes
Sep 27, 2019
Contributor
oscerd
left a comment
oscerd
left a comment
There was a problem hiding this comment.
The implementation looks good, but didn't we agree of enabling this behavior through an option?
Member
Author
|
@oscerd yeah, Initially I thought about the option config but then if we can use the type converter out of the box without hurting the existing behavior, would it be better? I think |
Contributor
|
Yes, if the existing behavior is the same, it's better for sure. |
Member
Author
|
Yeah the behavior didn't change, all testes untouched, just added 2 more tests :) |
omarsmak
changed the title
oscerd
approved these changes
Sep 28, 2019
davsclaus
approved these changes
Sep 30, 2019
fvaleri
pushed a commit
to fvaleri/camel
that referenced
this pull request
Oct 6, 2019
…e#3206) * CAMEL-13988: Initial protobuf converter from Map to Proto Message Signed-off-by: Omar Al-Safi <omarsmak@gmail.com> * CAMEL-13988: Add tests and modify documentation for protobuf dataformat Signed-off-by: Omar Al-Safi <omarsmak@gmail.com>
weiqiang123
pushed a commit
to weiqiang123/camel
that referenced
this pull request
Jan 20, 2020
…e#3206) * CAMEL-13988: Initial protobuf converter from Map to Proto Message Signed-off-by: Omar Al-Safi <omarsmak@gmail.com> * CAMEL-13988: Add tests and modify documentation for protobuf dataformat Signed-off-by: Omar Al-Safi <omarsmak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to add the support data of Map using data converters. It will convert Map to Proto Message using message descriptors.
Note: This PR is not breaking change as intends not to break any existing integration.