[CAMEL-13213] Cannot use rest-swagger component with swagger.json pro…#3374
Conversation
omarsmak
left a comment
There was a problem hiding this comment.
Thanks @JiriOndrusek , couples of nits here and there :)
...-rest-swagger/src/main/java/org/apache/camel/component/rest/swagger/RestSwaggerEndpoint.java
Outdated
Show resolved
Hide resolved
...-rest-swagger/src/main/java/org/apache/camel/component/rest/swagger/RestSwaggerEndpoint.java
Outdated
Show resolved
Hide resolved
...-rest-swagger/src/main/java/org/apache/camel/component/rest/swagger/RestSwaggerEndpoint.java
Outdated
Show resolved
Hide resolved
...-rest-swagger/src/main/java/org/apache/camel/component/rest/swagger/RestSwaggerEndpoint.java
Outdated
Show resolved
Hide resolved
...-rest-swagger/src/main/java/org/apache/camel/component/rest/swagger/RestSwaggerEndpoint.java
Outdated
Show resolved
Hide resolved
...-rest-swagger/src/main/java/org/apache/camel/component/rest/swagger/RestSwaggerEndpoint.java
Outdated
Show resolved
Hide resolved
|
@omarsmak thank you for your hints. I agree with a the majority of them (to be honest, I wanted to create this PR to have feedback whether this approach will be acceptable - I've completely forget to refactor for example method "getMethod", because I wasn't sure about this PR at all) |
6ed7a48 to
69db025
Compare
|
@omarsmak I've made all changes as requested |
...-rest-swagger/src/main/java/org/apache/camel/component/rest/swagger/RestSwaggerEndpoint.java
Show resolved
Hide resolved
|
@JiriOndrusek can you fix the last bit with closing that input stream after you are done |
|
Since camel-http is now required, then you need to change the karaf feature file to include it also You can add a new line with camel-http that is similar to camel-core |
…vided over HTTPS protocol
69db025 to
99c448e
Compare
|
@davsclaus Thank you for pointing it out. It is fixed now. |
…vided over HTTPS protocol (apache#3374)
…vided over HTTPS protocol
Issue: https://issues.apache.org/jira/browse/CAMEL-13213
There was on static call for swagger.json, which didn't care about ssl. I was trying to follow suggested direction from issue "What we should do is to load the resource via the chose camel http component and do a HTTP GET call. Then you setup SSL on it (as you would need to do to use https for the actual HTTP rest calls)."
So I've:
@davsclaus what do you think?