[CAMEL-14227]add a new camel-rest-openapi component and use apicurio-…#3384
Merged
ffang merged 13 commits intoapache:masterfrom Dec 5, 2019
Merged
[CAMEL-14227]add a new camel-rest-openapi component and use apicurio-…#3384ffang merged 13 commits intoapache:masterfrom
ffang merged 13 commits intoapache:masterfrom
Conversation
…data-module which can support OpenApi 2 & 3 at the same time
zregvart
reviewed
Dec 4, 2019
Member
zregvart
left a comment
zregvart
left a comment
There was a problem hiding this comment.
Thanks @ffang I found some nitpicking issues. Perhaps since using the Swagger API in the rest-swagger component is an internal detail we could replace it outright with the Apicurio model for OpenAPI and rename the component to rest-openapi and alias it to rest-swagger. I know it's safer to just add a new component, but that also comes with some maintenance burden...
components/camel-rest-openapi/src/main/docs/rest-openapi-component.adoc
Outdated
Show resolved
Hide resolved
components/camel-rest-openapi/src/main/docs/rest-openapi-component.adoc
Outdated
Show resolved
Hide resolved
components/camel-rest-openapi/src/main/docs/rest-openapi-component.adoc
Outdated
Show resolved
Hide resolved
components/camel-rest-openapi/src/main/docs/rest-openapi-component.adoc
Outdated
Show resolved
Hide resolved
components/camel-rest-openapi/src/main/docs/rest-openapi-component.adoc
Outdated
Show resolved
Hide resolved
...rest-openapi/src/main/java/org/apache/camel/component/rest/openapi/RestOpenApiComponent.java
Outdated
Show resolved
Hide resolved
...rest-openapi/src/main/java/org/apache/camel/component/rest/openapi/RestOpenApiComponent.java
Outdated
Show resolved
Hide resolved
...rest-openapi/src/main/java/org/apache/camel/component/rest/openapi/RestOpenApiComponent.java
Outdated
Show resolved
Hide resolved
...g-boot/components-starter/camel-rest-openapi-starter/src/main/resources/META-INF/LICENSE.txt
Show resolved
Hide resolved
...ng-boot/components-starter/camel-rest-openapi-starter/src/main/resources/META-INF/NOTICE.txt
Show resolved
Hide resolved
Contributor
|
I think a new camel-rest-openapi component is better, and then we can deprecate the old swagger. Its still early days in Camel 3 so it's fine. |
davsclaus
reviewed
Dec 5, 2019
components/camel-rest-openapi/src/test/resources/log4j2.properties
Outdated
Show resolved
Hide resolved
davsclaus
reviewed
Dec 5, 2019
…nent.adoc Co-Authored-By: Zoran Regvart <zoran@regvart.com>
…nent.adoc Co-Authored-By: Zoran Regvart <zoran@regvart.com>
…nent.adoc Co-Authored-By: Zoran Regvart <zoran@regvart.com>
…nent.adoc Co-Authored-By: Zoran Regvart <zoran@regvart.com>
…nent.adoc Co-Authored-By: Zoran Regvart <zoran@regvart.com>
…omponent/rest/openapi/RestOpenApiComponent.java Co-Authored-By: Zoran Regvart <zoran@regvart.com>
…omponent/rest/openapi/RestOpenApiComponent.java Co-Authored-By: Zoran Regvart <zoran@regvart.com>
…omponent/rest/openapi/RestOpenApiComponent.java Co-Authored-By: Zoran Regvart <zoran@regvart.com>
ffang
commented
Dec 5, 2019
Contributor
Author
ffang
left a comment
ffang
left a comment
There was a problem hiding this comment.
more polish and sync up
Contributor
Author
|
Thanks @zregvart and @davsclaus for the through feedback! And yes, I tend to keep camel-rest-swagger component for a while and deprecate it late on. All others revised accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…data-module which can support OpenApi 2 & 3 at the same time