Move camel-core-osgi-activator tests to Karaf itests

[zregvart]

Since OSGI activator depends on Karaf features it can only be built
after it, and since Karaf features include OSGI activator it fails as
the activator is not present in the Maven reactor at that point -- it
will be built right after it. This moves the tests, the only part that
depends on the Karaf features to the Karaf integration tests to prevent
this situation.

[zregvart]

Does this make sense for you @bobpaulin

[bobpaulin]

Yes the only thing I find troublesome is that now the test is a bit disconnected from the module itself. The feature does not require Karaf only an OSGi container. I show this in my original implementation https://github.com/bobpaulin/camel-main-osgi/blob/master/src/test/java/com/bobpaulin/camel/it/BundleIT.java . Doing an Apache Felix integration test in my module would allow the tests to occur without being dependent on the karaf features. Any concerns with me introducing the dependencies to do this once I move this to camel-osgi-activator under components?

[zregvart]

Any concerns with me introducing the dependencies to do this once I move this to camel-osgi-activator under components?

None at all from my end. Yeah it's a bit unlikely that the Karaf integration tests will be run on changing the OSGI activator. We would catch any issues on the build servers but that might be somewhat disconnected from the moment change is made and more difficult to troubleshoot.

Thanks!

[davsclaus]

I would object to that as we don't want yet another something to maintain. For osgi testing we use karaf itests and what we have with pax-exam.

[bobpaulin]

@davsclaus Would using the existing karaf/paxexam framework and just using direct bundle installs rather than features be acceptable? The reason you mention above is exactly why I converted the felix tests to karaf. Just trying to keep the test closer to the code. My use of features is what introduced the dependency cycle.

[davsclaus]

yeah sure