Bindy unicode patch#3552
Bindy unicode patch#3552davsclaus merged 4 commits intoapache:masterfrom mgr-lhm:bindy-unicode-patch
Conversation
components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/UnicodeHelper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I think this is a good improvement, but this requires adding a license notice for icu4j from what I'm seeing in other ASF projects. @davsclaus @gnodet what do you think?
| import com.ibm.icu.text.BreakIterator; | ||
|
|
||
| /** | ||
| * <p>Unterstützung für String-Verarbeitung für Unicode-Strings</p> |
There was a problem hiding this comment.
components/camel-bindy/pom.xml
Outdated
| </dependency> | ||
| <dependency> | ||
| <groupId>com.ibm.icu</groupId> | ||
| <artifactId>icu4j</artifactId> |
There was a problem hiding this comment.
Using this will require adding a license for this.
https://github.com/search?q=org%3Aapache+%27com.ibm.icu.icu4j%27&type=Code
Other projects are already using it, not sure this is a good idea, by the way.
components/camel-bindy/pom.xml
Outdated
| <description>Camel Bindy data format support</description> | ||
|
|
||
| <properties> | ||
| <icu4j.version>65.1</icu4j.version> |
There was a problem hiding this comment.
Please put the version property here as it is easier to manage
* Made UnicodeHelper Serializble and added toString().
|
@davsclaus about the icu4j dependency do we want to add a license file for it like Hive is doing? |
|
Yeah there are a number of other Apache projects use it as listed on this page (who is using) |
|
I adjusted the pull request as suggested:
|
|
We can do like we do in camel-salesforce, but for camel-bindy |
|
And configuring that option to choose how to count (eg that enum) should be added as an option to bindy data format in core (its a bit complex to do). But we can do that in a 2nd PR. |
|
Ah the count graphme option is configured on the model annotations, then this is fine. |
|
It was a pleasure to work with the Camel Community :-) @davsclaus: I have one more question on this topic: In which versions of camel will this improvement be available? Will it be back-ported to older versions and if yes to which? |
|
Camel 3.1, and no it wont be backported. |
4 participants
See Issue https://issues.apache.org/jira/browse/CAMEL-14521