Skip to content

[CAMEL-14861] fixed bug in GooglePubsubConsumer by initialized subscribers#3716

Merged
davsclaus merged 1 commit intoapache:masterfrom
taraktikos:fixed-npe-in-google-pubsub-consumer
Apr 8, 2020
Merged

[CAMEL-14861] fixed bug in GooglePubsubConsumer by initialized subscribers#3716
davsclaus merged 1 commit intoapache:masterfrom
taraktikos:fixed-npe-in-google-pubsub-consumer

Conversation

@taraktikos
Copy link
Contributor

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create also a JIRA issue, so we track this for 3.3.0 and report the issue number in the commit message

@taraktikos taraktikos force-pushed the fixed-npe-in-google-pubsub-consumer branch from 9859dd9 to 9d101eb Compare April 7, 2020 12:45
@taraktikos taraktikos changed the title [CAMEL-XXX] fixed bug in GooglePubsubConsumer by initialized subscribers [CAMEL-14861] fixed bug in GooglePubsubConsumer by initialized subscribers Apr 7, 2020
@taraktikos
Copy link
Contributor Author

@taraktikos taraktikos force-pushed the fixed-npe-in-google-pubsub-consumer branch from 9d101eb to 37cf14e Compare April 7, 2020 13:10
@taraktikos
Copy link
Contributor Author

@oscerd even in the master build is failing. What I did wrong?
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:checkstyle (default-cli) on project camel-core-xml: An error has occurred in Checkstyle report generation.: Failed during checkstyle execution: There is 1 error reported by Checkstyle 8.26 with camel-checkstyle.xml ruleset. -> [Help 1]

@oscerd
Copy link
Contributor

oscerd commented Apr 7, 2020

Nothing. It's not this PR.

@davsclaus davsclaus merged commit 8bfdd18 into apache:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants