Skip to content

CAMEL-14744: fix camel-salesforce lazy-login#3726

Merged
davsclaus merged 2 commits intoapache:masterfrom
MaartenTutak:master
Apr 16, 2020
Merged

CAMEL-14744: fix camel-salesforce lazy-login#3726
davsclaus merged 2 commits intoapache:masterfrom
MaartenTutak:master

Conversation

@MaartenTutak
Copy link
Contributor

This PR is an attempt to fix the lazy-login bug in the camel-salesforce component, which was logged in CAMEL-14744.

I would like some feedback on the chosen approach :

  1. Passing around SalesforceLoginConfig instead of a boolean value indicating lazyLogin
  2. "JIT" login in the SalesforceProducer#process method

This fix was tested against an actual Salesforce instance, via the DefaultRestClient implementation. I am unable to verify the other ApiClient implementations and things like the SubscriptionHelper, AbstractSalesforceMojo.

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
    Below are the contribution guidelines:
    https://github.com/apache/camel/blob/master/CONTRIBUTING.md

Copy link
Member

@omarsmak omarsmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MaartenTutak for the PR! Overall LGTM, just minor wildcard imports. Perhaps others can take a second look as well

import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wildcard import shouldn't happen, can you please re-import individual packages

@davsclaus
Copy link
Contributor

LGTM

@zregvart if you are around wonder if you could take 2 min to take a look.

@davsclaus davsclaus merged commit 3d99ff8 into apache:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments