CAMEL-14744: fix camel-salesforce lazy-login#3726
Merged
davsclaus merged 2 commits intoapache:masterfrom Apr 16, 2020
Merged
Conversation
omarsmak
requested changes
Apr 14, 2020
Member
omarsmak
left a comment
There was a problem hiding this comment.
Thank you @MaartenTutak for the PR! Overall LGTM, just minor wildcard imports. Perhaps others can take a second look as well
| import static org.mockito.Mockito.doNothing; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
| import static org.mockito.Mockito.*; |
Member
There was a problem hiding this comment.
The wildcard import shouldn't happen, can you please re-import individual packages
Contributor
|
LGTM @zregvart if you are around wonder if you could take 2 min to take a look. |
davsclaus
approved these changes
Apr 14, 2020
oscerd
approved these changes
Apr 14, 2020
omarsmak
approved these changes
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix the lazy-login bug in the camel-salesforce component, which was logged in CAMEL-14744.
I would like some feedback on the chosen approach :
This fix was tested against an actual Salesforce instance, via the DefaultRestClient implementation. I am unable to verify the other ApiClient implementations and things like the SubscriptionHelper, AbstractSalesforceMojo.
[CAMEL-XXX] Fixes bug in camel-file component, where you replaceCAMEL-XXXwith the appropriate JIRA issue.mvn clean install -Psourcecheckin your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md