Additional headers and properties support#4155
Closed
rgannu wants to merge 3 commits intoapache:camel-3.4.xfrom
Closed
Additional headers and properties support#4155rgannu wants to merge 3 commits intoapache:camel-3.4.xfrom
rgannu wants to merge 3 commits intoapache:camel-3.4.xfrom
Conversation
The additional headers will be added on top of the existing headers
from the message.
The properties added are only basic AMQP properties as defined in the
{@link com.rabbitmq.client.AMQP.BasicProperties.Builder}. When the
message contains already these properties then will be considered and
these additional properties will be ignored.
Made RabbitMQConstants to enum and added the documentation from docs.
ToDo: The documentation needs to be generated from the source code.
oscerd
requested changes
Sep 2, 2020
Contributor
oscerd
left a comment
oscerd
left a comment
There was a problem hiding this comment.
These are new options. This PR needs to be open against master and only there. 3.4.x is LTS
Contributor
|
Ckc Will be updated whenever the release is out (3.6.0 I mean) |
apache#323 Added support for additional headers and properties support The additional headers will be added on top of the existing headers from the message. The properties added are only basic AMQP properties as defined in the {@link com.rabbitmq.client.AMQP.BasicProperties.Builder}. When the message contains already these properties then will be considered and these additional properties will be ignored. Made RabbitMQConstants to enum and added the documentation from docs. ToDo: The documentation needs to be generated from the source code.
Contributor
|
Yes we cannot accept this on 3.4 branch as its for maintenance only (bug fixes and security stuff etc) not really for new features. Also that SimpleBeanDataHolder etc is not something we want. It should be a plain Map with just string, object or string, string types. |
Contributor
|
I believe we could close this, since 3.4.x is not a target. |
Contributor
Author
|
Yes.. I will create a new PR against master. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAMEL-15496 Support additional headers and properties
The additional headers will be added on top of the existing headers
from the message.
The properties added are only basic AMQP properties as defined in the
{@link com.rabbitmq.client.AMQP.BasicProperties.Builder}. When the
message contains already these properties then will be considered and
these additional properties will be ignored.
Made RabbitMQConstants to enum and added the documentation from docs.
ToDo: The documentation needs to be generated from the source code.