Skip to content

Migrates the camel-aws-sqs integration tests to the shared test infra#4476

Merged
orpiske merged 1 commit intoapache:masterfrom
orpiske:migrate-test-infra-aws-v1-with-test
Oct 19, 2020
Merged

Migrates the camel-aws-sqs integration tests to the shared test infra#4476
orpiske merged 1 commit intoapache:masterfrom
orpiske:migrate-test-infra-aws-v1-with-test

Conversation

@orpiske
Copy link
Copy Markdown
Contributor

@orpiske orpiske commented Oct 19, 2020

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
    Below are the contribution guidelines:
    https://github.com/apache/camel/blob/master/CONTRIBUTING.md

@orpiske orpiske force-pushed the migrate-test-infra-aws-v1-with-test branch from 7ebcd5e to d2e1c34 Compare October 19, 2020 09:12
Copy link
Copy Markdown
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I would probably focus on the Aws2 components. The v1 will be deprecated at some point

@orpiske
Copy link
Copy Markdown
Contributor Author

orpiske commented Oct 19, 2020

Thanks. I would probably focus on the Aws2 components. The v1 will be deprecated at some point

Thanks. I have that one in progress too :)

@orpiske orpiske force-pushed the migrate-test-infra-aws-v1-with-test branch from d2e1c34 to a2a3786 Compare October 19, 2020 09:29
@orpiske orpiske merged commit 5755e05 into apache:master Oct 19, 2020
@orpiske orpiske deleted the migrate-test-infra-aws-v1-with-test branch August 16, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants