Skip to content

Simplified exception testing#4672

Merged
davsclaus merged 1 commit intoapache:masterfrom
orpiske:assertions-cleanup
Nov 24, 2020
Merged

Simplified exception testing#4672
davsclaus merged 1 commit intoapache:masterfrom
orpiske:assertions-cleanup

Conversation

@orpiske
Copy link
Contributor

@orpiske orpiske commented Nov 24, 2020

Avoids false positives when the expected exception is thrown by a different method other than the one under test.

Components: camel-jetty

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
    Below are the contribution guidelines:
    https://github.com/apache/camel/blob/master/CONTRIBUTING.md

Avoids false positives when the expected exception is thrown by a different method other than the one under test.

Components: camel-jetty
@davsclaus davsclaus merged commit 0c5ec7a into apache:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants