Fix Consul key path used when determining leader.#4937
Merged
davsclaus merged 2 commits intoapache:masterfrom Jan 28, 2021
Merged
Fix Consul key path used when determining leader.#4937davsclaus merged 2 commits intoapache:masterfrom
davsclaus merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
@colin-mullikin thx for spotting this, is there any chance you also provide a test ? |
oscerd
approved these changes
Jan 26, 2021
colin-mullikin
force-pushed
the
consulLeader
branch
from
a4f77ab to
a59918c
Compare
lburgazzoli
approved these changes
Jan 27, 2021
The session lock is on the full key path, not on the root path. As far as I can tell, the result of this method isn't actually used anywhere, but this fix at least makes it correct.
colin-mullikin
force-pushed
the
consulLeader
branch
from
a59918c to
7c31668
Compare
Contributor
Author
|
Last push was just to add the Apache header to my test file. |
davsclaus
approved these changes
Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The session lock is on the full key path, not on the root path. As far as I can tell, the result of this method isn't actually used anywhere, but this fix at least makes it correct.
I discovered this issue due to my Consul ACL policy. My application has access to the full key path, but does not have access to the configured root path, so I was getting an error at startup.