Skip to content

Change SMPP default enquireLinkTimer from 5 seconds to 60 seconds.#5090

Merged
davsclaus merged 2 commits intoapache:masterfrom
pmoerenhout:smpp_enquire_link_timer
Feb 16, 2021
Merged

Change SMPP default enquireLinkTimer from 5 seconds to 60 seconds.#5090
davsclaus merged 2 commits intoapache:masterfrom
pmoerenhout:smpp_enquire_link_timer

Conversation

@pmoerenhout
Copy link
Copy Markdown
Contributor

@pmoerenhout pmoerenhout commented Feb 15, 2021

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
    Below are the contribution guidelines:
    https://github.com/apache/camel/blob/master/CONTRIBUTING.md

Change the default SMPP enquireLinkTime from 5 to 60 seconds. The default of 5 seconds is too aggressive for default connections not specifying an other value.

Copy link
Copy Markdown
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there is no JIRA issue about this change.

@pmoerenhout
Copy link
Copy Markdown
Contributor Author

I can create the Jira, no problem, I also see that the sourcecheck failed on the imports. Will redo the PR...

@oscerd
Copy link
Copy Markdown
Contributor

oscerd commented Feb 15, 2021

The sourcecheck is failing for another commit, the jira is not really needed, I was noticiing this because you marked the first point of PR template

@PascalSchumacher
Copy link
Copy Markdown
Contributor

+1, at work we also changed it to 60 seconds years ago, because the SMSC colleagues complained about the 5 second interval.

@davsclaus davsclaus merged commit f2bd8c7 into apache:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants