Change SMPP default enquireLinkTimer from 5 seconds to 60 seconds.#5090
Merged
davsclaus merged 2 commits intoapache:masterfrom Feb 16, 2021
Merged
Change SMPP default enquireLinkTimer from 5 seconds to 60 seconds.#5090davsclaus merged 2 commits intoapache:masterfrom
davsclaus merged 2 commits intoapache:masterfrom
Conversation
oscerd
approved these changes
Feb 15, 2021
Contributor
oscerd
left a comment
There was a problem hiding this comment.
LGTM but there is no JIRA issue about this change.
Contributor
Author
|
I can create the Jira, no problem, I also see that the sourcecheck failed on the imports. Will redo the PR... |
Contributor
|
The sourcecheck is failing for another commit, the jira is not really needed, I was noticiing this because you marked the first point of PR template |
davsclaus
approved these changes
Feb 15, 2021
oscerd
approved these changes
Feb 15, 2021
Contributor
|
+1, at work we also changed it to 60 seconds years ago, because the SMSC colleagues complained about the 5 second interval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[CAMEL-XXX] Fixes bug in camel-file component, where you replaceCAMEL-XXXwith the appropriate JIRA issue.mvn clean install -Psourcecheckin your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
Change the default SMPP enquireLinkTime from 5 to 60 seconds. The default of 5 seconds is too aggressive for default connections not specifying an other value.