Mark NatsEndpoint as supporting MultipleConsumers.#5106
Merged
Conversation
Per nats documentation: NATS implements a publish-subscribe message distribution model for one-to-many communication.
oscerd
requested changes
Feb 20, 2021
Contributor
oscerd
left a comment
There was a problem hiding this comment.
This means that the component supports multiple camel consumers. This is not obvious and it doesn't depend from Nats, but from camel.
Contributor
Author
Isn't it effectively a matter of whether or not it is safe to make multiple subscriptions from the same topic here: Or is there something else that needs to be changed? |
Contributor
|
Ah yeah, the NatsConsumer is using the executorService, so this is correct. My fault Sorry. |
oscerd
approved these changes
Feb 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark
NatsEndpointas supportingMultipleConsumers.Per nats documentation:
NATS implements a publish-subscribe message distribution model for one-to-many communication.