Skip to content

CAMEL-16400: split unit and integration tests for camel-aws2-sqs#5304

Merged
orpiske merged 1 commit intoapache:masterfrom
orpiske:camel-16400-aws2-sqs
Apr 7, 2021
Merged

CAMEL-16400: split unit and integration tests for camel-aws2-sqs#5304
orpiske merged 1 commit intoapache:masterfrom
orpiske:camel-16400-aws2-sqs

Conversation

@orpiske
Copy link
Copy Markdown
Contributor

@orpiske orpiske commented Apr 7, 2021

Run all tests:
mvn verify

Run unit tests:
mvn test

To skip all tests:
mvn -DskipTests=true

To skip integration tests (default from failsafe):
mvn -DskipITs=true verify

Unit tests only run in 23s
Integration + unit tests run in 2 min 12s

@orpiske
Copy link
Copy Markdown
Contributor Author

orpiske commented Apr 7, 2021

@davsclaus @gnodet @oscerd FYI, this breaks the unit and integration tests in different phases in Maven. Wdyt?

@davsclaus
Copy link
Copy Markdown
Contributor

How does it work with

mvn clean install -P fastinstall

Its a habit I use for rebuilding the code (not tests at all)

Copy link
Copy Markdown
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

@orpiske
Copy link
Copy Markdown
Contributor Author

orpiske commented Apr 7, 2021

How does it work with

mvn clean install -P fastinstall

Its a habit I use for rebuilding the code (not tests at all)

With fastinstall profile, it skips all the tests. I think this is the current behavior, right?

@davsclaus
Copy link
Copy Markdown
Contributor

Yes thanks.

This is really great. No verbose pom.xml, and we can easily test for users not with docker.

I wonder if we can have the failsafe plugin in the components/pom.xml so you dont need it per component?

@orpiske
Copy link
Copy Markdown
Contributor Author

orpiske commented Apr 7, 2021

Yes thanks.

This is really great. No verbose pom.xml, and we can easily test for users not with docker.

Thanks

I wonder if we can have the failsafe plugin in the components/pom.xml so you dont need it per component?

I think we can probably do that once we finish migrating all of them. IMHO, it would be safer to keep it as a plugin reference for now, and then cleanup after the migration is complete.

@davsclaus
Copy link
Copy Markdown
Contributor

Ok sounds good

@oscerd
Copy link
Copy Markdown
Contributor

oscerd commented Apr 7, 2021

The cs error should be fixed. Just rebase and merge @orpiske

@orpiske
Copy link
Copy Markdown
Contributor Author

orpiske commented Apr 7, 2021

The cs error should be fixed. Just rebase and merge @orpiske

Fantastic! Thanks @oscerd!

@orpiske orpiske force-pushed the camel-16400-aws2-sqs branch from 3a14b66 to 68c9ed9 Compare April 7, 2021 12:58
@orpiske orpiske merged commit a3b340f into apache:master Apr 7, 2021
@orpiske orpiske deleted the camel-16400-aws2-sqs branch August 16, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants