Skip to content

camel-braintree: test fixes and improvements #5376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davsclaus merged 1 commit into from
Apr 15, 2021
Merged

camel-braintree: test fixes and improvements #5376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions components/camel-braintree/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Camel Braintree Component

# Running the integration tests

This component contains integration tests that must be executed against the Braintree sandbox. In
order to do so, you need to setup an account as explained in the [testing guide](https://developers.braintreepayments.com/reference/general/testing/java).

Then, login to the Sandbox instance, collect the merchantId, publicKey and privateKey and edit the
test-options.properties file in the test resources directory. Also, uncomment the environment option.

```
environment = SANDBOX
merchantId = merchant ID taken from sandbox ui
publicKey = key from sandbox ui
privateKey = private key from sandbox ui
```

Then, you can use the following commands to run the tests:

```
CAMEL_BRAINTREE_REPORT_DATE=$(date '+%Y-%m-%d') CAMEL_BRAINTREE_MERCHANT_ACCOUNT_ID="merchant ID taken from sandbox" ui mvn -Pbraintree-test clean verify
```

It's also possible to run a smaller set of tests by running them without the environment variables:
```
mvn -Pbraintree-test clean verify
```
22 changes: 21 additions & 1 deletion ...ree/src/test/java/org/apache/camel/component/braintree/DisputeGatewayIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ public void testAccept() throws Exception {
final Result result = requestBody(
"direct://ACCEPT",
createdDispute.getId());

LOG.info("Result message: {}", result.getMessage());
assertNotNull(result, "accept result");
assertTrue(result.isSuccess(), "accept result success");

Expand All @@ -98,6 +100,7 @@ public void testAddFileEvidence() throws Exception {
null,
headers);

LOG.info("Result message: {}", result.getMessage());
assertNotNull(result, "addFileEvidence result");
assertTrue(result.isSuccess(), "addFileEvidence result success");
}
Expand All @@ -118,6 +121,7 @@ public void testAddFileEvidenceOne() throws Exception {
null,
headers);

LOG.info("Result message: {}", result.getMessage());
assertNotNull(result, "addFileEvidence result");
assertTrue(result.isSuccess(), "addFileEvidence result success");
}
Expand All @@ -137,6 +141,7 @@ public void testAddTextEvidence() throws Exception {
null,
headers);

LOG.info("Result message: {}", result.getMessage());
assertNotNull(result, "addTextEvidence result");
assertTrue(result.isSuccess(), "addTextEvidence result success");

Expand All @@ -161,6 +166,7 @@ public void testAddTextEvidenceOne() throws Exception {
null,
headers);

LOG.info("Result message: {}", result.getMessage());
assertNotNull(result, "addTextEvidence result");
assertTrue(result.isSuccess(), "addTextEvidence result success");

Expand All @@ -176,12 +182,15 @@ public void testFinalize() throws Exception {
final Result result = requestBody(
"direct://FINALIZE",
createdDispute.getId());

LOG.info("Result message: {}", result.getMessage());
assertNotNull(result, "finalize result");
assertTrue(result.isSuccess(), "finalize result success");

final Dispute finalizedDispute = requestBody(
"direct://FIND",
createdDispute.getId());

assertNotNull(finalizedDispute, "finalized dispute");
assertEquals(Dispute.Status.DISPUTED, finalizedDispute.getStatus());
}
Expand Down Expand Up @@ -214,6 +223,7 @@ public void testRemoveEvidence() throws Exception {
null,
addTextEvidenceHeaders);

LOG.info("Result message: {}", addTextEvidenceResult.getMessage());
assertNotNull(addTextEvidenceResult, "addTextEvidence result");
assertTrue(addTextEvidenceResult.isSuccess(), "addTextEvidence result success");

Expand All @@ -229,6 +239,7 @@ public void testRemoveEvidence() throws Exception {
null,
removeTextEvidenceHeaders);

LOG.info("Result message: {}", removeTextEvidenceResult.getMessage());
assertNotNull(removeTextEvidenceResult, "removeEvidence result");
assertTrue(removeTextEvidenceResult.isSuccess(), "removeEvidence result success");
}
Expand Down Expand Up @@ -301,11 +312,19 @@ public void configure() {
};
}

private static int randomWithRange(int min, int max) {
int range = (max - min) + 1;

return (int) (Math.random() * range) + min;
}

private Dispute createDispute() {
return createDispute(100.00);
double initialAmount = randomWithRange(100, 200);
return createDispute(initialAmount);
}

private Dispute createDispute(double amount) {
LOG.info("Creating dispute with amount {}", amount);
final Result<Transaction> transactionResult = requestBody(
"direct://SALE",
new TransactionRequest()
Expand All @@ -319,6 +338,7 @@ private Dispute createDispute(double amount) {
.done(),
Result.class);

LOG.info("Result message: {}", transactionResult.getMessage());
assertTrue(transactionResult.isSuccess());
List<Dispute> disputes = transactionResult.getTarget().getDisputes();
assertListSize(disputes, 1);
Expand Down
7 changes: 7 additions & 0 deletions ...tree/src/test/java/org/apache/camel/component/braintree/ReportGatewayIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
import org.apache.camel.component.braintree.internal.BraintreeApiCollection;
import org.apache.camel.component.braintree.internal.ReportGatewayApiMethod;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable;
import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariables;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand All @@ -40,6 +42,10 @@ public class ReportGatewayIntegrationTest extends AbstractBraintreeTestSupport {
private static final String PATH_PREFIX
= BraintreeApiCollection.getCollection().getApiName(ReportGatewayApiMethod.class).getName();

@EnabledIfEnvironmentVariables({
@EnabledIfEnvironmentVariable(named = "CAMEL_BRAINTREE_MERCHANT_ACCOUNT_ID", matches = ".*"),
@EnabledIfEnvironmentVariable(named = "CAMEL_BRAINTREE_REPORT_DATE", matches = ".*")
})
@Test
public void testTransactionLevelFees() throws Exception {
String merchantAccountId = System.getenv("CAMEL_BRAINTREE_MERCHANT_ACCOUNT_ID");
Expand All @@ -57,6 +63,7 @@ public void testTransactionLevelFees() throws Exception {
"direct://TRANSACTIONLEVELFEES",
request);

LOG.info("Result message: {}", result.getMessage());
assertNotNull(result, "transactionLevelFees result");
assertTrue(result.isSuccess(), "transactionLevelFees success");
TransactionLevelFeeReport report = result.getTarget();
Expand Down
25 changes: 17 additions & 8 deletions ...src/test/java/org/apache/camel/component/braintree/TransactionGatewayIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ public void testSale() throws Exception {
.done(),
Result.class);

LOG.info("Result message: {}", result.getMessage());
assertNotNull(result, "sale result");
assertTrue(result.isSuccess());

Expand All @@ -106,13 +107,14 @@ public void testCloneTransaction() throws Exception {
final Result<Transaction> createResult = requestBody(
"direct://SALE",
new TransactionRequest()
.amount(new BigDecimal("100.00"))
.amount(new BigDecimal("100.01"))
.paymentMethodNonce("fake-valid-nonce")
.options()
.submitForSettlement(false)
.done(),
Result.class);

LOG.info("Result message: {}", createResult.getMessage());
assertNotNull(createResult, "sale result");
assertTrue(createResult.isSuccess());

Expand Down Expand Up @@ -148,13 +150,14 @@ public void testFind() throws Exception {
final Result<Transaction> createResult = requestBody(
"direct://SALE",
new TransactionRequest()
.amount(new BigDecimal("100.00"))
.amount(new BigDecimal("100.02"))
.paymentMethodNonce("fake-valid-nonce")
.options()
.submitForSettlement(false)
.done(),
Result.class);

LOG.info("Result message: {}", createResult.getMessage());
assertNotNull(createResult, "sale result");
assertTrue(createResult.isSuccess());

Expand All @@ -175,13 +178,14 @@ public void testSubmitForSettlementWithId() throws Exception {
final Result<Transaction> createResult = requestBody(
"direct://SALE",
new TransactionRequest()
.amount(new BigDecimal("100.00"))
.amount(new BigDecimal("100.03"))
.paymentMethodNonce("fake-valid-nonce")
.options()
.submitForSettlement(false)
.done(),
Result.class);

LOG.info("Result message: {}", createResult.getMessage());
assertNotNull(createResult, "sale result");
assertTrue(createResult.isSuccess());

Expand All @@ -204,13 +208,14 @@ public void testSubmitForSettlementWithIdAndAmount() throws Exception {
final Result<Transaction> createResult = requestBody(
"direct://SALE",
new TransactionRequest()
.amount(new BigDecimal("100.00"))
.amount(new BigDecimal("100.04"))
.paymentMethodNonce("fake-valid-nonce")
.options()
.submitForSettlement(false)
.done(),
Result.class);

LOG.info("Result message: {}", createResult.getMessage());
assertNotNull(createResult, "sale result");
assertTrue(createResult.isSuccess());

Expand All @@ -237,13 +242,14 @@ public void testSubmitForSettlementWithRequest() throws Exception {
final Result<Transaction> createResult = requestBody(
"direct://SALE",
new TransactionRequest()
.amount(new BigDecimal("100.00"))
.amount(new BigDecimal("100.05"))
.paymentMethodNonce("fake-valid-nonce")
.options()
.submitForSettlement(false)
.done(),
Result.class);

LOG.info("Result message: {}", createResult.getMessage());
assertNotNull(createResult, "sale result");
assertTrue(createResult.isSuccess());

Expand Down Expand Up @@ -271,13 +277,14 @@ public void testRefund() throws Exception {
final Result<Transaction> createResult = requestBody(
"direct://SALE",
new TransactionRequest()
.amount(new BigDecimal("100.00"))
.amount(new BigDecimal("100.06"))
.paymentMethodNonce("fake-valid-nonce")
.options()
.submitForSettlement(true)
.done(),
Result.class);

LOG.info("Result message: {}", createResult.getMessage());
assertNotNull(createResult, "sale result");
assertTrue(createResult.isSuccess());

Expand All @@ -304,13 +311,14 @@ public void testRefundWithAmount() throws Exception {
final Result<Transaction> createResult = requestBody(
"direct://SALE",
new TransactionRequest()
.amount(new BigDecimal("100.00"))
.amount(new BigDecimal("100.07"))
.paymentMethodNonce("fake-valid-nonce")
.options()
.submitForSettlement(true)
.done(),
Result.class);

LOG.info("Result message: {}", createResult.getMessage());
assertNotNull(createResult, "sale result");
assertTrue(createResult.isSuccess());

Expand Down Expand Up @@ -341,13 +349,14 @@ public void testRefundWithRequest() throws Exception {
final Result<Transaction> createResult = requestBody(
"direct://SALE",
new TransactionRequest()
.amount(new BigDecimal("100.00"))
.amount(new BigDecimal("100.08"))
.paymentMethodNonce("fake-valid-nonce")
.options()
.submitForSettlement(true)
.done(),
Result.class);

LOG.info("Result message: {}", createResult.getMessage());
assertNotNull(createResult, "sale result");
assertTrue(createResult.isSuccess());

Expand Down