fixes based on static analysis check with FindBugs#5842
Merged
orpiske merged 8 commits intoapache:mainfrom Jul 21, 2021
dk2k:dk2k-components-static-analysis
Merged
fixes based on static analysis check with FindBugs#5842orpiske merged 8 commits intoapache:mainfrom dk2k:dk2k-components-static-analysis
orpiske merged 8 commits intoapache:mainfrom
dk2k:dk2k-components-static-analysis
Conversation
oscerd
approved these changes
Jul 18, 2021
orpiske
requested changes
Jul 19, 2021
Contributor
orpiske
left a comment
orpiske
left a comment
There was a problem hiding this comment.
Thanks for helping keeping the code code tidy and clean! I added a few notes about the log messages, as it would make it easier for users to figure out what went wrong should they ever happen.
...camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Producer.java
Outdated
Show resolved
Hide resolved
components/camel-coap/src/main/java/org/apache/camel/coap/CamelCoapResource.java
Outdated
Show resolved
Hide resolved
components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/FtpOperations.java
Outdated
Show resolved
Hide resolved
components/camel-hdfs/src/main/java/org/apache/camel/component/hdfs/HdfsNormalFileHandler.java
Outdated
Show resolved
Hide resolved
...ts/camel-jetty-common/src/main/java/org/apache/camel/component/jetty/CamelFilterWrapper.java
Outdated
Show resolved
Hide resolved
...ts/camel-jetty-common/src/main/java/org/apache/camel/component/jetty/JettyHttpComponent.java
Outdated
Show resolved
Hide resolved
components/camel-lucene/src/main/java/org/apache/camel/component/lucene/LuceneIndexer.java
Outdated
Show resolved
Hide resolved
components/camel-jbpm/src/main/java/org/apache/camel/component/jbpm/JBPMConsumer.java
Outdated
Show resolved
Hide resolved
orpiske
reviewed
Jul 19, 2021
...ts/camel-jetty-common/src/main/java/org/apache/camel/component/jetty/CamelFilterWrapper.java
Outdated
Show resolved
Hide resolved
orpiske
reviewed
Jul 19, 2021
components/camel-lucene/src/main/java/org/apache/camel/component/lucene/LuceneIndexer.java
Outdated
Show resolved
Hide resolved
orpiske
reviewed
Jul 19, 2021
components/camel-hdfs/src/main/java/org/apache/camel/component/hdfs/HdfsNormalFileHandler.java
Outdated
Show resolved
Hide resolved
orpiske
requested changes
Jul 19, 2021
Contributor
orpiske
left a comment
orpiske
left a comment
There was a problem hiding this comment.
Thanks for the changes! It's looking better, but the usage of log markers is incorrect. I added some examples, but there may be more.
orpiske
requested changes
Jul 20, 2021
Contributor
orpiske
left a comment
orpiske
left a comment
There was a problem hiding this comment.
This is looking great, thanks for the changes! I think the only remaining items I see are the commented blocks. Once removing that, we should be good to go.
| // prefer to use endpoint configured over component configured | ||
| if (jettyBinding == null) { | ||
| // unused | ||
| /*if (jettyBinding == null) { |
Contributor
There was a problem hiding this comment.
I think we can remove this block of code if it's unused. It would make it easier for us when/if bisecting the code in case of problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.