Skip to content

CAMEL-16853: fix resultHandlerFactory, add unit test#5945

Merged
davsclaus merged 5 commits intoapache:mainfrom
rikvb:main
Aug 10, 2021
Merged

CAMEL-16853: fix resultHandlerFactory, add unit test#5945
davsclaus merged 5 commits intoapache:mainfrom
rikvb:main

Conversation

@rikvb
Copy link
Contributor

@rikvb rikvb commented Aug 9, 2021

Unit test provided that demonstrates the flaw in current code.

rikvb and others added 2 commits August 9, 2021 18:44
CAMEL-16853: fix resultHandlerFactory, add unit test
@davsclaus
Copy link
Contributor

There is a cycle dependency with maven now

Error: ] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.apache.camel:camel-test-spring-junit5:3.12.0-SNAPSHOT'}' and 'Vertex{label='org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT'}' introduces to cycle in the graph org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT --> org.apache.camel:camel-management:3.12.0-SNAPSHOT --> org.apache.camel:camel-core:3.12.0-SNAPSHOT --> org.apache.camel:camel-xslt:3.12.0-SNAPSHOT --> org.apache.camel:camel-test-spring-junit5:3.12.0-SNAPSHOT --> org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT @ 
Error:  The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.apache.camel:camel-test-spring-junit5:3.12.0-SNAPSHOT'}' and 'Vertex{label='org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT'}' introduces to cycle in the graph org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT --> org.apache.camel:camel-management:3.12.0-SNAPSHOT --> org.apache.camel:camel-core:3.12.0-SNAPSHOT --> org.apache.camel:camel-xslt:3.12.0-SNAPSHOT --> org.apache.camel:camel-test-spring-junit5:3.12.0-SNAPSHOT --> org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT -> [Help 1]

Can you avoid using camel-test-spring5 and just build a unit test that are Java DSL based

@rikvb
Copy link
Contributor Author

rikvb commented Aug 10, 2021

Apologies, I borrowed some code from saxon-xslt since it's very similar and forgot to check for this. I have rewritten the unit test using DSL and camel-test-junit5, but the cyclic dependency still exists:

cyclic reference: Edge between
'Vertex{label='org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT'}' and
'Vertex{label='org.apache.camel:camel-management:3.12.0-SNAPSHOT'}'
introduces to cycle in the graph
org.apache.camel:camel-management:3.12.0-SNAPSHOT
--> org.apache.camel:camel-core:3.12.0-SNAPSHOT
--> org.apache.camel:camel-xslt:3.12.0-SNAPSHOT
--> org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT
--> org.apache.camel:camel-management:3.12.0-SNAPSHOT @

Any suggestions?

rikvb added 2 commits August 10, 2021 08:23
CAMEL-16853: Change unit test to DSL version, without depending on spring (note: still cyclic!)
@davsclaus
Copy link
Contributor

Yes the unit test should not be in camel-xslt, but in core/camel-core, there are some xslt tests there

CAMEL-16853: Fix cyclic dep: Moved unit test to camel-core, removed test dependencies from camel-xslt
@rikvb
Copy link
Contributor Author

rikvb commented Aug 10, 2021

Moved test to core, reverted changes to camel-xslt pom. Change is now just 1 new unit test and a 3-line move

@davsclaus davsclaus merged commit 0f2f7e0 into apache:main Aug 10, 2021
davsclaus pushed a commit that referenced this pull request Aug 10, 2021
* CAMEL-16853: fix resultHandlerFactory, add unit test

* CAMEL-16853: Change unit test to DSL version, without depending on spring (note: still cyclic!)

* CAMEL-16853: Fix cyclic dep: Moved unit test to camel-core, removed test dependencies from camel-xslt

Co-authored-by: Rik van Ballegooijen <rik@codecast.nl>
davsclaus pushed a commit that referenced this pull request Aug 10, 2021
* CAMEL-16853: fix resultHandlerFactory, add unit test

* CAMEL-16853: Change unit test to DSL version, without depending on spring (note: still cyclic!)

* CAMEL-16853: Fix cyclic dep: Moved unit test to camel-core, removed test dependencies from camel-xslt

Co-authored-by: Rik van Ballegooijen <rik@codecast.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants