Skip to content

Comments

[CAMEL-16907] camel-jt400 program call usability and doc improvements#6019

Merged
davsclaus merged 6 commits intoapache:mainfrom
ThePrez:jt400-pgmcall-usability
Sep 2, 2021
Merged

[CAMEL-16907] camel-jt400 program call usability and doc improvements#6019
davsclaus merged 6 commits intoapache:mainfrom
ThePrez:jt400-pgmcall-usability

Conversation

@ThePrez
Copy link
Contributor

@ThePrez ThePrez commented Aug 31, 2021

Added usability improvements to the program call support as documented in the referenced JIRA issue.

Also, snuck in some doc improvements:

  • Stopped referring to it as "remote program call" as we have a lot of people running Camel on IBM i now
  • Removed the 'type' path parameter (it's not required since the type is inferred from the path)
  • added a more practical program call example

@ThePrez ThePrez marked this pull request as draft September 1, 2021 02:34
@ThePrez
Copy link
Contributor Author

ThePrez commented Sep 1, 2021

Converting to draft to add doc to more explicitly address concerns in this JIRA ticket

@ThePrez
Copy link
Contributor Author

ThePrez commented Sep 1, 2021

I pushed a couple more commits. e2d6043 stops handling input parameters based on whether it's in binary mode. In the old design, binary mode required a byte[] and text mode required a String, now it is tolerant enough to accept either.

e54d709 clarifies the parameter handling in the documentation to address the concern in CAMEL-16899

@ThePrez ThePrez marked this pull request as ready for review September 1, 2021 23:10
@davsclaus davsclaus merged commit 39beca8 into apache:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants