CAMEL-17489: camel-kafka - Unsubscribe before closing the consumer#6751
Merged
orpiske merged 1 commit intoapache:mainfrom Jan 14, 2022
rgala:main
Merged
CAMEL-17489: camel-kafka - Unsubscribe before closing the consumer#6751orpiske merged 1 commit intoapache:mainfrom rgala:main
orpiske merged 1 commit intoapache:mainfrom
rgala:main
Conversation
orpiske
approved these changes
Jan 14, 2022
orpiske
reviewed
Jan 14, 2022
| // only close if not retry | ||
| if (!isRetrying()) { | ||
| LOG.debug("Closing consumer {}", threadId); | ||
| safeUnsubscribe(); |
Contributor
There was a problem hiding this comment.
An exception here might trigger the exception handler ... but I guess it's OK.
davsclaus
approved these changes
Jan 14, 2022
Contributor
|
I think eg make safeUnsubscrive catch IllegalStateException and ignore that |
Contributor
Yeah, I think it may be OK to ignore the |
Contributor
|
I am merging this, and then I'll improve the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.