CAMEL-9420 camel-paho : provide dynamic qos and rentained option#730
Closed
gautric wants to merge 3 commits intoapache:masterfrom
Closed
CAMEL-9420 camel-paho : provide dynamic qos and rentained option#730gautric wants to merge 3 commits intoapache:masterfrom
gautric wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
do not use dots in keys, and the getHeader method has a default value you can pass in, so you can do that in one line instead of using containsKey. Also we would like to see an unit test to test such change. |
Contributor
|
thanks its merged, do you mind closing |
Contributor
Author
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.