CAMEL-18023. camel-jbang command options from application.properties#7511
Merged
mgubaidullin merged 3 commits intoapache:mainfrom Apr 28, 2022
Merged
Conversation
Contributor
|
🚫 There are (likely) no components to be tested in this PR |
davsclaus
approved these changes
Apr 28, 2022
Contributor
|
🚫 There are (likely) no components to be tested in this PR |
orpiske
reviewed
Apr 28, 2022
| try (FileInputStream fis = new FileInputStream(defaultsFile)) { | ||
| properties.load(fis); | ||
| } catch (IOException e) { | ||
| LOG.error("Error", e); |
Contributor
There was a problem hiding this comment.
I am probably nitpicking a bit, but ... maybe wouldn't it be better to also log the exception message? I.e.:
LOG.error("Error reading defaults file: {}", e.getMessage, e);
orpiske
approved these changes
Apr 28, 2022
Contributor
|
🚫 There are (likely) no components to be tested in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CAMEL-18023