Merged
Conversation
Contributor
|
|
Contributor
|
✔️ Finished component verification: 0 component(s) test failed out of 1 component(s) tested |
davsclaus
reviewed
May 10, 2022
zhfeng
force-pushed
the
update_kafka_transaction_doc
branch
from
68ab931 to
83b5bf8
Compare
davsclaus
approved these changes
May 10, 2022
Contributor
|
I think it would be good if we could make configuring the TX options as new endpoint options so its easier and more tooling friendly. Additional properties is only intended for special and rare use-cases. |
Contributor
|
✔️ Finished component verification: 0 component(s) test failed out of 1 component(s) tested |
Contributor
Author
|
Thanks @davsclaus
Does it make sense? |
Contributor
|
Yeah but name it transactionId without the dot in the uri option |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.