Convert non-persistent JMS tests to the test infra#8163
Merged
Conversation
Contributor
|
|
Contributor
|
❌ Finished component verification: 1 component(s) test failed out of 1 component(s) tested |
orpiske
force-pushed
the
convert-jms-to-test-infra
branch
2 times, most recently
from
4889a9d to
b904f13
Compare
Contributor
|
❌ Finished component verification: 1 component(s) test failed out of 1 component(s) tested |
davsclaus
approved these changes
Aug 16, 2022
Contributor
|
❌ Finished component verification: 1 component(s) test failed out of 1 component(s) tested |
orpiske
force-pushed
the
convert-jms-to-test-infra
branch
2 times, most recently
from
e8b9e10 to
4747fb1
Compare
Contributor
|
❌ Finished component verification: 1 component(s) test failed out of 4 component(s) tested |
Contributor
|
❌ Finished component verification: 1 component(s) test failed out of 5 component(s) tested |
- this reworks several tests relying on a non-persistent broker to use the equivalent service in the test-infra - moves some of the legacy code to test-infra - minor test cleanups (mostly logs) - avoid sharing resources as a pre-work for future parallelization
orpiske
force-pushed
the
convert-jms-to-test-infra
branch
from
4747fb1 to
ff799f5
Compare
Contributor
|
✔️ Finished component verification: 0 component(s) test failed out of 1 component(s) tested |
Contributor
Author
|
Checkstyle failure is not on this code, so merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: there's still a lot more to be done here, but given the number of
tests, let's do it in small steps.