CAMEL-18520 Google-secrets-manager:resolved conflicts #8388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good to me, but I'd like to test it |
oscerd
approved these changes
Sep 16, 2022
Contributor
Author
|
I agree that test have to be run. |
Contributor
|
Yeah, I mean against the real service. |
Contributor
Author
|
Do you have an opportunity to run those real tests (like having a real configured account) or should I try to run it? |
Contributor
|
Yes. |
Contributor
|
I have a real account to test with and I'll check next week. |
davsclaus
approved these changes
Sep 16, 2022
Contributor
|
We could merge. I'll test next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://issues.apache.org/jira/browse/CAMEL-18520
I aligned versions of google-secret-manager to com.google.cloud/libraries-bom/25.4.0 (which dictates versions to other google dependencies)
@oscerd What do you think about it? (The fix removes conflicts from the issue and make sense to me)