Adds tests to demonstrate bug within the toD optimisation#8396
Merged
davsclaus merged 1 commit intoapache:mainfrom Sep 23, 2022
Merged
Adds tests to demonstrate bug within the toD optimisation#8396davsclaus merged 1 commit intoapache:mainfrom
davsclaus merged 1 commit intoapache:mainfrom
Conversation
Contributor
|
|
Contributor
|
❌ Finished component verification: 1 component(s) test failed out of 1 component(s) tested |
Contributor
|
Can you create a JIRA ticket about this |
Contributor
|
I created a ticket |
davsclaus
pushed a commit
that referenced
this pull request
Sep 23, 2022
Co-authored-by: Jeroen Bellen <jeroenb@aviobook.aero>
Contributor
Author
|
@davsclaus Thanks for the fast response and fix! Any chance that the fix can be included within the 3.14.x ? |
davsclaus
pushed a commit
that referenced
this pull request
Sep 26, 2022
Co-authored-by: Jeroen Bellen <jeroenb@aviobook.aero>
geekrupam
pushed a commit
to geekrupam/camel
that referenced
this pull request
Oct 7, 2022
Co-authored-by: Jeroen Bellen <jeroenb@aviobook.aero>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toD optimisation does not work when a path variable contains a space.
The HTTP component correctly encodes spaces to %20, but the HttpSendDynamicAware does not follow this logic.
This triggers an URISyntaxException because java.net.URI (on line 168) does not accept an unencoded URL.
It might be worthwhile to add some logging when an URISyntaxException is handled. Currently, it goes unnoticed.