Skip to content

CAMEL-18764: camel-core - templatedRoute builder from Java cannot use…#8782

Merged
davsclaus merged 2 commits into
mainfrom
templatedroutes
Nov 28, 2022
Merged

CAMEL-18764: camel-core - templatedRoute builder from Java cannot use…#8782
davsclaus merged 2 commits into
mainfrom
templatedroutes

Conversation

@davsclaus
Copy link
Copy Markdown
Contributor

… templates from other DSLs

@davsclaus davsclaus requested a review from essobedo November 27, 2022 13:15
@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

⚠️ Please note that the changes on this PR may be tested automatically.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@github-actions github-actions Bot added the core label Nov 27, 2022
@davsclaus
Copy link
Copy Markdown
Contributor Author

The problem is that RouteBuilder now with templatedRoute can trigger too early. So we need to move this out of its normal route add logic, and make templated routes last.

It would be good to add unit test for this in core.

If you look at how ConfigureRouteTemplates was in use previously then its invoked last after all the regular route add stuff, so this PR does like what it does.

addDiscoveredRoutes(camelContext, routes);

@github-actions
Copy link
Copy Markdown
Contributor

🚫 There are (likely) no components to be tested in this PR

Comment thread core/camel-api/src/main/java/org/apache/camel/CamelContext.java Outdated
Co-authored-by: Nicolas Filotto <essobedo@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

🚫 There are (likely) no components to be tested in this PR

@davsclaus davsclaus merged commit 623651f into main Nov 28, 2022
@davsclaus davsclaus deleted the templatedroutes branch November 28, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants