Skip to content

CAMEL-18757 Specify type for pom-only artifacts like camel-*-parent#8783

Merged
davsclaus merged 3 commits into
apache:mainfrom
cunningt:CAMEL-18757
Nov 29, 2022
Merged

CAMEL-18757 Specify type for pom-only artifacts like camel-*-parent#8783
davsclaus merged 3 commits into
apache:mainfrom
cunningt:CAMEL-18757

Conversation

@cunningt
Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/CAMEL-18757

Check the model of each component for the packaging type. If a pom, express that in the parent and the bom.

Did some parent/pom.xml cleanup as well - I checked through the entries for core, dsl, and catalog and added dependency entries for any missing artifacts under those sections. Fixed some spacing issues in parent/pom.xml generation.

@github-actions
Copy link
Copy Markdown
Contributor

🚫 There are (likely) no components to be tested in this PR

@github-actions
Copy link
Copy Markdown
Contributor

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 0 1

@davsclaus
Copy link
Copy Markdown
Contributor

davsclaus commented Nov 28, 2022

I wonder if maven plugins such as

 <dependency>
        <groupId>org.apache.camel</groupId>
        <artifactId>camel-vertx-kafka-maven-plugin</artifactId>
        <version>${project.version}</version>
      </dependency>

Should have

<type>maven-plugin</type>

https://maven.apache.org/ref/3.8.6/maven-core/artifact-handlers.html

A plugin has

 <packaging>maven-plugin</packaging>

@cunningt
Copy link
Copy Markdown
Contributor Author

cunningt commented Nov 28, 2022

Can definitely make that change but in the other projects that I've checked (cxf, karaf) the type isn't included in the bom for maven-plugin. The reason I'm keen to make this change is that the lack of <type>pom</type> is an issue for parent dependencies because no jars exist for that dependency - and it causes errors on certain bom resolution programs that default to looking for a jar. In the case of maven-plugins, a jar definitely exists.

@davsclaus
Copy link
Copy Markdown
Contributor

Okay its fine if others dont do that - also I dont think its a real problem, for end users that import this BOM

@davsclaus davsclaus merged commit 941c5f6 into apache:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants