CAMEL-18757 Specify type for pom-only artifacts like camel-*-parent#8783
Merged
Conversation
Contributor
|
🚫 There are (likely) no components to be tested in this PR |
Contributor
Components tested:
|
Contributor
|
I wonder if maven plugins such as Should have https://maven.apache.org/ref/3.8.6/maven-core/artifact-handlers.html A plugin has |
Contributor
Author
|
Can definitely make that change but in the other projects that I've checked (cxf, karaf) the type isn't included in the bom for maven-plugin. The reason I'm keen to make this change is that the lack of |
Contributor
|
Okay its fine if others dont do that - also I dont think its a real problem, for end users that import this BOM |
davsclaus
approved these changes
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CAMEL-18757
Check the model of each component for the packaging type. If a pom, express that in the parent and the bom.
Did some parent/pom.xml cleanup as well - I checked through the entries for core, dsl, and catalog and added dependency entries for any missing artifacts under those sections. Fixed some spacing issues in parent/pom.xml generation.