Google Spreadsheets tests refactoring#8788
Merged
davsclaus merged 1 commit intoapache:mainfrom Nov 30, 2022
Merged
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 If necessary Apache Camel Committers may access logs and test results in the job summaries! |
Contributor
Components tested:
|
Contributor
It seems to be failing due to checkstyle issues. |
oscerd
approved these changes
Nov 29, 2022
bvfalcon
force-pushed
the
google-sheets-tests-refactoring
branch
from
b86c28e to
0e39a92
Compare
Contributor
Author
Yes, you are right. Some conventional things were forgotten. Solved now |
Contributor
Components tested:
|
davsclaus
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the Image 1 is shown work of application with Google Spreadspeets component in "real-life"-mode
Image 1 - Real work
Tests before (link side) and after (right side) this PR are shown at the Image 2
Image 2 - Tests changes
Advantages of new schema:
Dependencies Citrus Framework, Spring Security, AssertJ are used by embedded server. These dependencies are test-scoped and were used only to mock remote Google Services. This is not necessary: Google Api Client itself supports test-mode.
OAuth2 Mock server is build with Spring Security OAuth library which is deprecated. Implementing new OAuth2 Mock server using new Spring component is difficult because required profound knowledge of OAuth2 protocol. And this is not necessary ;) -- Google Api Client library makes this work for us.
(!) Not solved problem: both schemas - old and new - have no control of Sheets API change. If this API changes, component will work in corrupted mode. Make this check is possible with analysis of Sheets API Schema, but this aspect is out of scoped for this PR and will stay for future.