cleanup tests after enabling by the previous commit #8913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Dec 17, 2022
Contributor
|
🚫 There are (likely) no components to be tested in this PR |
davsclaus
approved these changes
Dec 18, 2022
Contributor
|
🚫 There are (likely) no components to be tested in this PR |
1 similar comment
Contributor
|
🚫 There are (likely) no components to be tested in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 negative tests being disabled in 2013:
aaf3eb9
They are re-enabled today:
e589921
And run pretty fast (so no need to wait up to 30 or 40 seconds anymore)
This PR attempts to cleanup these tests a bit.