Skip to content

CAMEL-19050: add DHIS2 component#9349

Closed
cjmamo wants to merge 8 commits into
apache:mainfrom
dhis2:CAMEL-19050
Closed

CAMEL-19050: add DHIS2 component#9349
cjmamo wants to merge 8 commits into
apache:mainfrom
dhis2:CAMEL-19050

Conversation

@cjmamo
Copy link
Copy Markdown
Contributor

@cjmamo cjmamo commented Feb 14, 2023

Description

Add DHIS2 Camel Component.

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I formatted the code using mvn -Pformat,fastinstall install && mvn -Psourcecheck

@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

⚠️ Please note that the changes on this PR may be tested automatically.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@davsclaus
Copy link
Copy Markdown
Contributor

Thanks for the contribution.

However all the source code must use the ASF license header. So either you need to change this in the PR or we cannot accept the PR to ASF.

Also it would be good to write a bit more in the .doc file what dhis2 is. Just a few lines to explain it to users that do not know.

Copy link
Copy Markdown
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code needs to have the ASF License header in all the files.

Comment thread components/camel-dhis2/LICENSE Outdated
Comment thread components/camel-dhis2/camel-dhis2-api/pom.xml Outdated
@cjmamo cjmamo marked this pull request as draft February 22, 2023 13:38
reference latest dhis2-java-sdk release
@cjmamo cjmamo marked this pull request as ready for review February 22, 2023 18:43
@cjmamo cjmamo requested a review from oscerd February 22, 2023 18:44
Copy link
Copy Markdown
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll try to merge it this week.

@oscerd
Copy link
Copy Markdown
Contributor

oscerd commented Feb 24, 2023

Trying to merge this but it's failing with

[ERROR] Failed to execute goal on project camel-dhis2: Could not resolve dependencies for project org.apache.camel:camel-dhis2:jar:4.0.0-SNAPSHOT: Could not find artifact org.apache.camel:camel-dhis2-api:jar:javadoc:4.0.0-SNAPSHOT in apache-public (https://repository.apache.org/content/groups/public/)

@oscerd
Copy link
Copy Markdown
Contributor

oscerd commented Feb 24, 2023

I removed the javadoc camel-dhis2-api jar, tests were passing. Merged and pushed. Thanks

@oscerd oscerd closed this Feb 24, 2023
@cjmamo cjmamo deleted the CAMEL-19050 branch March 9, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants