Skip to content

Comments

camel-milo: Fix lost dataChangeFilterTrigger#9455

Merged
essobedo merged 1 commit intoapache:camel-3.xfrom
rangoy:bugfix/milo-filterconfiguration-3.x
Mar 1, 2023
Merged

camel-milo: Fix lost dataChangeFilterTrigger#9455
essobedo merged 1 commit intoapache:camel-3.xfrom
rangoy:bugfix/milo-filterconfiguration-3.x

Conversation

@rangoy
Copy link
Contributor

@rangoy rangoy commented Mar 1, 2023

Description

Milo component does not use dataChangeFilterTrigger value from route, this was replaced by StatusValueTimestamp during setup.

Ref https://issues.apache.org/jira/browse/CAMEL-19100

Target

Targets 3.x branch as camel-milo is disabled in 4.x branch, waiting for jakarata update of eclipse milo, ref eclipse-milo/milo#1098

This is the same as #9451 but rebased for 3.x branch

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I formatted the code using mvn -Pformat,fastinstall install && mvn -Psourcecheck

Milo component does not use dataChangeFilterTrigger value from route, this was replaced by StatusValueTimestamp during setup.

Default filter is now set to StatusValueTimestamp as this will keep the current behaviour.

Ref https://issues.apache.org/jira/browse/CAMEL-19100
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

🌟 Thank you for your contribution to the Apache Camel project! 🌟

⚠️ Please note that the changes on this PR may be tested automatically.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 0 1

@essobedo
Copy link
Contributor

essobedo commented Mar 1, 2023

The checkstyle issue is not related and has been fixed by 18383df, let's merging it.

@rangoy many thanks for your efforts 🙏

@essobedo essobedo merged commit 273d3ed into apache:camel-3.x Mar 1, 2023
@rangoy rangoy deleted the bugfix/milo-filterconfiguration-3.x branch March 1, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants