deliveryTag -> For manual ack#9471
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 If necessary Apache Camel Committers may access logs and test results in the job summaries! |
Components tested:
|
1 similar comment
Components tested:
|
|
Are you able to update the docs (see src/main/docs) about this delivery tag and how to do a manual ack |
oscerd
left a comment
There was a problem hiding this comment.
I think deliveryTag String should be declared in the Constants class.
Yes |
Thanks for reviewing , Will add this documentation |
|
any update? |
Updated the docs and added constant as well |
Components tested:
|
|
I wonder if the delivery tag only make sense to have as a header if ack mode is manual? Are there situations where you need this information elsewhere ? |
Yes Even i am not aware of scenario where we would need this elsewhere , But having and header would anyways help and gives flexibility to opt for it or not , What are your thoughts |
|
Thanks @davsclaus / @oscerd , Are we good to merge this |
Components tested:
|
* deliveryTag -> For manual ack * Adding DELIVERY_TAG as constant * Referring DELIVERY_TAG constants * Adding readme docs for manual acknowledgement * Fixing checkstyle
Description
Target
camel-3.x, whereas Camel 4 uses themainbranch)Tracking
Apache Camel coding standards and style
mvn -Pformat,fastinstall install && mvn -Psourcecheck