Skip to content

Comments

CAMEL-19198: 3.x branch version -- Added sorting logic to ensure dynamic router eip component filters are evaluated in order of their priority property#9638

Merged
davsclaus merged 1 commit intoapache:camel-3.xfrom
Steve973:CAMEL-19198-3.x
Mar 26, 2023

Conversation

@Steve973
Copy link
Contributor

CAMEL-19198: Added sorting logic to ensure dynamic router eip component filters are evaluated in order of their priority property

Description

When filters are evaluated, the filters are now sorted by priority before being evaluated.

Target

  • [x ] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • [x ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • [x ] I checked that each commit in the pull request has a meaningful subject line and body.

  • [x ] I formatted the code using mvn -Pformat,fastinstall install && mvn -Psourcecheck

…nt filters are evaluated in order of their priority property, and updated tests.
@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

⚠️ Please note that the changes on this PR may be tested automatically.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@Steve973 Steve973 changed the title CAMEL-19198: Added sorting logic to ensure dynamic router eip component filters are evaluated in order of their priority property CAMEL-19198: 3.x branch version -- Added sorting logic to ensure dynamic router eip component filters are evaluated in order of their priority property Mar 25, 2023
@davsclaus
Copy link
Contributor

backport this to 3.20.x and 3.18.x via cherry-pick

@github-actions
Copy link
Contributor

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 0 1

@Steve973
Copy link
Contributor Author

@davsclaus I ran checkstyle on the entire code base, and it showed no violations. And that was in addition to mvn -Pformat,fastinstall install && mvn -Psourcecheck. Any idea why it failed? The details didn't help me understand what went wrong.

@davsclaus davsclaus merged commit 9da8e73 into apache:camel-3.x Mar 26, 2023
davsclaus pushed a commit that referenced this pull request Mar 26, 2023
…nt filters are evaluated in order of their priority property, and updated tests. (#9638)
davsclaus pushed a commit that referenced this pull request Mar 26, 2023
…nt filters are evaluated in order of their priority property, and updated tests. (#9638)
jamesnetherton pushed a commit to jamesnetherton/camel that referenced this pull request Mar 28, 2023
…nt filters are evaluated in order of their priority property, and updated tests. (apache#9638)
jamesnetherton pushed a commit to jamesnetherton/camel that referenced this pull request Mar 28, 2023
…nt filters are evaluated in order of their priority property, and updated tests. (apache#9638)
jamesnetherton pushed a commit to jamesnetherton/camel that referenced this pull request Mar 28, 2023
…nt filters are evaluated in order of their priority property, and updated tests. (apache#9638)
@Steve973 Steve973 deleted the CAMEL-19198-3.x branch January 17, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants