(chores) performance: use native array copying which may benefit from intrinsic functions#9954
Merged
orpiske merged 1 commit intoapache:mainfrom Apr 26, 2023
Merged
Conversation
… intrinsic functions
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 If necessary Apache Camel Committers may access logs and test results in the job summaries! |
Contributor
|
🚫 There are (likely) no components to be tested in this PR |
oscerd
approved these changes
Apr 26, 2023
davsclaus
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java's
System.arraycopyis instrinsified, so, in theory, it should provide better performance (when supported/available on the platform/etc) at best and equivalent performance to the existing one at worst.Running on my test HW, it seems to indicate a small performance gain compared to existing code:
W/ this:
Geometric mean: 714894.9672412889 Standard deviation: 39656.14503166896Baseline
Geometric mean: 666166.262717514 Standard deviation: 53664.56234237712But it was not an extensive test, so the results are probably overly dramatic here.