Skip to content

Removing unused parameters from method signature#9975

Closed
lhsribas wants to merge 1 commit intoapache:mainfrom
lhsribas:unused-parameters
Closed

Removing unused parameters from method signature#9975
lhsribas wants to merge 1 commit intoapache:mainfrom
lhsribas:unused-parameters

Conversation

@lhsribas
Copy link

@lhsribas lhsribas commented May 2, 2023

Description

I have worked on the following class removing the unused parameters from method signature.

Tracking

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

🌟 Thank you for your contribution to the Apache Camel project! 🌟

⚠️ Please note that the changes on this PR may be tested automatically.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @lhsribas.

As I explained on ZulipChat, the PR is a little bit too big for us to review. Maybe try to break it into smaller pieces (one for core, another for component, etc).

@orpiske
Copy link
Contributor

orpiske commented May 2, 2023

Folks, I've been giving some ideas/help for @lhsribas on his first contribution to Camel. Please, feel free to step in and provide more comments.

@rhuan080
Copy link
Contributor

rhuan080 commented May 2, 2023

Hi,

I would like to suggest using method overload to createBaseDescription and turning the method with unused parameters deprecated. Thus, you can change the call to the need method in many other PRs. I think it is the more secure approach.

@orpiske
Copy link
Contributor

orpiske commented Jun 20, 2023

This one has stalled, therefore closing.

@orpiske orpiske closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants