Removing unused parameters from method signature#9975
Closed
lhsribas wants to merge 1 commit intoapache:mainfrom
Closed
Removing unused parameters from method signature#9975lhsribas wants to merge 1 commit intoapache:mainfrom
lhsribas wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 If necessary Apache Camel Committers may access logs and test results in the job summaries! |
Contributor
|
Folks, I've been giving some ideas/help for @lhsribas on his first contribution to Camel. Please, feel free to step in and provide more comments. |
Contributor
|
Hi, I would like to suggest using method overload to createBaseDescription and turning the method with unused parameters deprecated. Thus, you can change the call to the need method in many other PRs. I think it is the more secure approach. |
Contributor
|
This one has stalled, therefore closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have worked on the following class removing the unused parameters from method signature.
Tracking